PNE-6228: Replace Travis CI with Github Actions #320
Conversation
mVenetos97
changed the title
.github/workflows/merge_workflow.yml
Outdated
| test: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: |
There was a problem hiding this comment.
Using a matrix here feels a bit awkward since you need custom logic for each. Might be more clear to have two separate jobs that run in parallel.
There was a problem hiding this comment.
Good point, I split into separate jobs.
.github/workflows/merge_workflow.yml
Outdated
| if: matrix.test-type == 'scala' | ||
| uses: actions/setup-java@v2 | ||
| with: | ||
| java-version: ${{ env.JAVA_VERSION }} |
There was a problem hiding this comment.
are these env vars set? I don't see them. Same with the secrets you reference.
There was a problem hiding this comment.
No, I just have them set in the yml itself
.github/workflows/merge_workflow.yml
Outdated
| distribution: 'adopt' | ||
| - name: Release to Maven Central | ||
| env: | ||
| PGP_PASSPHRASE: ${{ secrets.PGP_PASSPHRASE }} |
There was a problem hiding this comment.
what are these secrets? Have you set them? How do they get used?
There was a problem hiding this comment.
These are for deploying and they are set in Github
.github/workflows/merge_workflow.yml
Outdated
| - name: Build and publish to PyPI | ||
| env: | ||
| TWINE_USERNAME: __token__ | ||
| TWINE_PASSWORD: ${{ secrets.PYPI_API_TOKEN }} |
There was a problem hiding this comment.
Is this the same token as from the repo used by our other python libraries (citrine-python & gemd-python)?
There was a problem hiding this comment.
Yes but I dont think you can share them across our libraries
| python-version: ["3.8"] | ||
| os: [ubuntu-latest] |
There was a problem hiding this comment.
An earlier commit had python 3.8-3.12 and also had mac and windows OS. Unfortunately, it looks like lolo is not up to date so I reverted back to ubuntu and 3.8. I plan to make another PR to bring lolo into the present
Move from travis CI to github actions