hds-2183: fix header ssr styles #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrTuomoK
approved these changes
Apr 10, 2024
The order of css rules in production SSR (next.js/Gatsby) seems to be different than in React SPA. If component styles are imported before subcomponents, the css rule order seem to be consistent.
There are no mixins or scss vars in the header.module.scss, so this @use only adds unused css-classes to built css.
NikoHelle
force-pushed
the
hds-2183-header-ssr-styles
branch
from
57205dc to
77f6395
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The order of css classes in SSR (next.js/Gatsby) was different than in "normal" React SPA.
The issue was fixed by re-ordering imports in Header.tsx. The components own style module should be imported before sub components to keep css classes in same order in React and SSR.
Added also an Eslint rule to force
./*.module.scssto be imported before other internal imports. This caused 200+ changes in this PR when Eslint was run with--fixThere was also a weird way to use
Header.module.scssin most of the sub components by using@use. This caused Header styles to be duplicated. Removing this resulted in 30kb smallerindex.cssfile.Built css-files are attached in "css-files.zip". The files are "beautified" with css-beautifier to make comparison easier.
Related Issue
Closes HDS-2183
Motivation and Context
How Has This Been Tested?
nextjs-hds-example.zip
css-files.zip
Add to changelog