-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 3.7.0 #1256
Merged
Merged
Release 3.7.0 #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hds-2065 changed to default domain and added new version cookie. Changed <Link> in index.mdx to <ExternalLink> because <Link> does not remove new line <p> tags.
…-guidelines (HDS-2015) Cookie documentation update
Fetch-mock was not enable so actual http-requests were made. Silent renewal was also on by default. No need for that.
Same change to other tests
Fix login tests
Added remark that hero should not be used with side navigation. Update CHANGELOG.md Added line for not using hero with side navigation.
Fixed typo in mobile heading example Update CHANGELOG.md Added line in changelog
* Changed Getting started-for designers section to Figma era. * updated CHANGELOG
…es-prop to React-component
…ton-styles-examples (HDS-2110) Link with Button styles
Mock stores cookies now with key <cookie name><domain><path>. This way multiple cookies can be added, and certain ccookies deleted. If cookie maxAge < 1 or expiration date has passed, the cookie should be deleted not added.
It is a proxy between cookieConsentController and cookieController. It does what cookieController does, but on initialization it removes and converts old data and adds version cookie.
The consent and consent version cookies are automatically added to content. Name, id and, hostname are set automatically.
The listed hostName for the storage cookie must be same as the cookies domain.
…-domain-cleaned HDS-2065: change default cookie domain
hds-2065 changed the default domain and made shared consents obsolete. A new version cookie was also added.
…-consent-documentation HDS-2014 Update cookie consent documentation
Currently, the FileInput component doesn't accept capitalized versions of filenames when an extension is specified. So if you accept ".png", "image.PNG" is not accepted. Convert both the filter and the filename to lowercase before comparing to make the validation case-insensitive.
…ypography-docs (HDS-2178) fix: Fixed typo in mobile heading example
…documentation HDS-1726 improve hero documentation
HDS-2112: Deprecate combobox
Hds 2218 fix file input
…tors HDS-2192: Hide footer separators from screen readers
The props that are not with 100% certainty in the new version are marked deprecated. Only few remain in the new one.
- Updated Getting started-section for designers from Sketch/Abstract guidelines to Figma guidelines - This includes: Contributing guide, FAQ, Versioning, and a new Figma tutorial
…lect-props HDS-2200: Mark most props of the Select component deprecated
The order of css rules in production SSR (next.js/Gatsby) seems to be different than in React SPA. If component styles are imported before subcomponents, the css rule order seem to be consistent.
There are no mixins or scss vars in the header.module.scss, so this @use only adds unused css-classes to built css.
…yles hds-2183: fix header ssr styles
NikoHelle
force-pushed
the
release-3.7.0
branch
from
April 11, 2024 08:35
32ef72d
to
9f1c491
Compare
NikoHelle
force-pushed
the
release-3.7.0
branch
from
April 11, 2024 08:46
4383810
to
65d48ae
Compare
laurakarhu
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it!
NikoHelle
force-pushed
the
release-3.7.0
branch
from
April 11, 2024 09:12
9c94cae
to
64d8816
Compare
mrTuomoK
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New version 3.7.0