Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(HDS-2225) fix iconkit workflow not to build if already up-to-date #1257

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

mrTuomoK
Copy link
Contributor

@mrTuomoK mrTuomoK commented Apr 11, 2024

Description

Icon kit workflow unnecessarily fetched from Figma and builds the zip, set to skip them if version is already the same.

Related Issue

HDS-2225

How Has This Been Tested?

  • running the workflow -> can be tested when the package.json version numbers match the icon kit version number and manually triggering the workflow to run.

Add to changelog

  • No need to add to changelog

@mrTuomoK mrTuomoK requested a review from a team April 11, 2024 09:37
Copy link
Contributor

@NikoHelle NikoHelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit :D

@mrTuomoK mrTuomoK force-pushed the HDS-2225-release-icon-workflow-fix branch from 58d0738 to 22d6686 Compare April 11, 2024 11:45
@mrTuomoK mrTuomoK merged commit 8d4effa into development Apr 11, 2024
6 of 7 checks passed
@mrTuomoK mrTuomoK deleted the HDS-2225-release-icon-workflow-fix branch April 11, 2024 12:02
@laurakarhu laurakarhu added this to the HDS 3.8.0 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants