HDS-1836 Notification size to enum + HDS-1832 ErrorSummary size to enum #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurakarhu
added
the
Breaking changes
mrTuomoK
force-pushed
the
HDS-1836-notification-size-to-enum
branch
from
d8f71a5 to
0854e1f
Compare
mrTuomoK
changed the title
NikoHelle
approved these changes
Jun 3, 2024
mrTuomoK
force-pushed
the
HDS-1836-notification-size-to-enum
branch
from
0854e1f to
49f7e07
Compare
Test Results1 tests 1 ✅ 0s ⏱️ Results for commit 49f7e07. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change Notification size prop to enum. Also does the same for ErrorSummary.
Related Issue
HDS-1836
HDS-1832
How Has This Been Tested?
Demos:
Docs
Core Storybook
React Storybook
Screenshots (if appropriate):
Add to changelog