Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDS-2147 update icon list on docsite #1284

Merged
merged 15 commits into from
May 23, 2024
Merged

Conversation

terovirtanen
Copy link
Contributor

@terovirtanen terovirtanen commented May 6, 2024

Description

Script to update docsite icons list. The script is run as part of the update-icon-library -action. The icons list is updated when the icons are updated.

Generated icons list has been updated to site/src/docs/foundation/visual-assets/icons/list.mdx

HDS-2147

Related Issue

Closes #

Motivation and Context

How Has This Been Tested?

Demos:

Links to demos are in the comments

Screenshots (if appropriate):

Add to changelog

  • Added needed line to changelog

Copy link

github-actions bot commented May 6, 2024

Test Results

1 tests   1 ✅  0s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 17801f6.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 6, 2024

Preview found from hds-demo docs/preview_1284

Demos

Docs
Core Storybook
React Storybook

@terovirtanen terovirtanen requested a review from mrTuomoK May 6, 2024 11:09
.github/workflows/hds-demo-preview.yml Outdated Show resolved Hide resolved
.github/workflows/hds-demo-preview.yml Outdated Show resolved Hide resolved
.github/workflows/update-icon-library.yml Outdated Show resolved Hide resolved
.github/workflows/hds-demo-preview.yml Show resolved Hide resolved
site/scripts/iconlist.js Outdated Show resolved Hide resolved
site/scripts/iconlist.js Outdated Show resolved Hide resolved
@terovirtanen terovirtanen requested a review from NikoHelle May 16, 2024 08:39
site/scripts/iconlist.js Outdated Show resolved Hide resolved
site/scripts/iconlist.js Outdated Show resolved Hide resolved
Copy link
Contributor

@NikoHelle NikoHelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments about comments and console.log

@terovirtanen terovirtanen requested a review from NikoHelle May 22, 2024 07:21
@terovirtanen terovirtanen merged commit 725f083 into development May 23, 2024
8 checks passed
@terovirtanen terovirtanen deleted the docsite_icons_HDS-2147 branch May 23, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants