fix: keyboard navigation and scroll in select component #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timwessman
force-pushed
the
hds-2600-fix-select-keyboard-scroll
branch
from
5be7261 to
7699855
Compare
Test Results 1 files 68 suites 12m 55s ⏱️ Results for commit 124e889. ♻️ This comment has been updated with latest results. |
|
Preview found from hds-demo docs/preview_1467 Demos |
mrTuomoK
requested changes
Jan 29, 2025
mrTuomoK
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed keyboard navigation in select component. Now keyboard arrow up/down move focus in select component and don't scroll parent container. But anyway parent container will scroll automatically to keep focused option visible, this still happens when focused option is near view bottom
Related Issue
Closes HDS-2600
How Has This Been Tested?
Manually
Demos:
Links to demos are in the comments
Screenshots (if appropriate):
Add to changelog