Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an access code when approving a reservation without one #1513

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

matti-lamppu
Copy link
Collaborator

@matti-lamppu matti-lamppu commented Jan 30, 2025

🛠️ Changelog

  • Create an access code when approving a reservation without one. This can happen in a denied reservation returns to handling and is then approved.
  • Modify return to handling mutation to not make the deactivate call if access code was removed.

🧪 Test plan

  • Automated tests

🚧 Dependencies

  • None

🎫 Tickets

@matti-lamppu matti-lamppu self-assigned this Jan 30, 2025
@matti-lamppu matti-lamppu added the improvement Improves an existing feature label Jan 30, 2025
@matti-lamppu matti-lamppu requested review from ranta and vergama January 30, 2025 10:57
@matti-lamppu matti-lamppu marked this pull request as ready for review January 30, 2025 10:57
@matti-lamppu matti-lamppu force-pushed the create-access-code-on-confirm branch from 6cf0101 to 11f2b84 Compare January 30, 2025 11:13
@matti-lamppu matti-lamppu force-pushed the create-access-code-on-confirm branch 2 times, most recently from 285c978 to 11f2b84 Compare January 30, 2025 14:21
@matti-lamppu matti-lamppu force-pushed the create-access-code-on-confirm branch from 11f2b84 to 2e0432c Compare January 31, 2025 06:15
This can happen in a denied reservation returns to handling and is
then approved. Also modify return to handling mutation to not make
the deactivate call if access code was removed.
@matti-lamppu matti-lamppu force-pushed the create-access-code-on-confirm branch from 2e0432c to 5bc0d71 Compare January 31, 2025 08:11
Base automatically changed from access-code-tasks to update-pindora-client January 31, 2025 08:46
@matti-lamppu matti-lamppu merged commit 5bc0d71 into update-pindora-client Jan 31, 2025
19 checks passed
@matti-lamppu matti-lamppu deleted the create-access-code-on-confirm branch January 31, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants