CU-86a6av7kx - BSEthereum - Throw last error if no transfer is succes…

…sful
CityOfZion · Jan 22, 2025 · b1a1532 · b1a1532
1 parent 98c8e5f
commit b1a1532
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/common/changes/@cityofzion/bs-ethereum/CU-86a6av7kx_2025-01-22-18-23.json b/common/changes/@cityofzion/bs-ethereum/CU-86a6av7kx_2025-01-22-18-23.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@cityofzion/bs-ethereum",
+      "comment": "Throw last error if no transfer is successful",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@cityofzion/bs-ethereum"
+}
diff --git a/packages/bs-ethereum/src/BSEthereum.ts b/packages/bs-ethereum/src/BSEthereum.ts
@@ -227,6 +227,7 @@ export class BSEthereum<BSName extends string = string>
     const signer = await this.#generateSigner(param.senderAccount)
 
     const sentTransactionHashes: string[] = []
+    let error: Error | undefined
 
     for (const intent of param.intents) {
       let transactionHash = ''
@@ -247,14 +248,19 @@ export class BSEthereum<BSName extends string = string>
           maxPriorityFeePerGas: gasPrice,
           maxFeePerGas: gasPrice,
         })
+
         transactionHash = transaction.hash
-      } catch {
-        /* empty */
+      } catch (err: any) {
+        error = err
       }
 
       sentTransactionHashes.push(transactionHash)
     }
 
+    if (error && sentTransactionHashes.every(hash => !hash)) {
+      throw error
+    }
+
     return sentTransactionHashes
   }