Note that HERE %iles are interpolated values, not necessarily observed in samples #897
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I.e. HERE calculates percentiles with something like PostgreSQL's
percentile_cont
rather thanpercentile_disc
as I had originally assumed. This means that except where thesample_size = 3
(for the median) orsample_size = 20
( for the 85th), the percentile values are almost certain to be interpolated rather than actually observed in the sample.This can be demonstrated by looking at records
WHERE sample_size = 2
What this pull request accomplishes:
Issue(s) this solves:
What, in particular, needs to reviewed:
What needs to be done by a sysadmin after this PR is merged
NA