Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple PTC ratios imputer #39

Merged
merged 2 commits into from
Jan 22, 2020
Merged

Simple PTC ratios imputer #39

merged 2 commits into from
Jan 22, 2020

Conversation

cczhu
Copy link
Contributor

@cczhu cczhu commented Jan 21, 2020 •
edited
Loading

Scaled down prototype of a PTC imputer. Currently only works to plug holes in ratio derived values like MADT to day-of-month ADT ratio, but can serve as the basis for more sophisticated imputation experiments when we finally get around to it.

Resolves #33 (since the advanced stuff got moved to #38).

@cczhu cczhu self-assigned this Jan 21, 2020
@cczhu cczhu added countmatch Pythonization of PRTCS into CountMatch module enhancement New feature or request labels Jan 21, 2020
cczhu
cczhu commented Jan 22, 2020
View reviewed changes
Copy link
Contributor Author

@cczhu cczhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes only.

traffic_prophet/countmatch/derivedvals.py Show resolved Hide resolved
traffic_prophet/countmatch/tests/test_derivedvals.py Outdated Show resolved Hide resolved
traffic_prophet/countmatch/derivedvals.py Outdated Show resolved Hide resolved
traffic_prophet/countmatch/tests/test_derivedvals.py Show resolved Hide resolved
@cczhu cczhu merged commit 50707a5 into countmatch Jan 22, 2020
@cczhu cczhu deleted the ptc_imputer branch January 22, 2020 04:59
@cczhu cczhu mentioned this pull request Jan 22, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cczhu cczhu

Labels
countmatch Pythonization of PRTCS into CountMatch module enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cczhu