Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding time integrator version of non-equilibrium formulation #456

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
aa27f12
added time integration version of documentation
Aug 19, 2024
60c33fe
added time integrator version of MM2015
Aug 20, 2024
99f3ddd
added documentation for time integrator script
Aug 20, 2024
ac01d79
added function to API
Aug 20, 2024
1df902b
adding tests for time integrator
Aug 20, 2024
acab4a4
set correct values for smoke tests
Aug 20, 2024
c606a64
added time integrator mixed phase test
Aug 20, 2024
173f2c0
fixed math in note problem
Aug 20, 2024
ce47cba
ran formatter
Aug 20, 2024
8bcce7b
added rtol to 0 tests
Aug 20, 2024
ea58131
made vertical vel 0 for the 0 tests
Aug 20, 2024
fb481c7
removed zero tests
Aug 20, 2024
91dd46d
fixed the smoke test
Aug 20, 2024
a4bf7c1
again
Aug 20, 2024
bbf368e
again
Aug 20, 2024
2759fbd
implementing quick bug fix
Sep 4, 2024
aaffea6
Temporary fix for unstable ice bound
trontrytel Aug 20, 2024
c510475
Add ice melting rate to P3
trontrytel Aug 21, 2024
432e5f5
P3 velocities with liquid fraction (#440)
rorlija1 Aug 22, 2024
eee7707
Bump version for a new release, delete NEWS.md
trontrytel Aug 23, 2024
508d03e
made test error value larger
Sep 9, 2024
f4781ba
Bug fix for non-eq microphysics, bump patch version
Aug 30, 2024
868a3b8
tmp remove P3 scheme from performance tests
trontrytel Sep 6, 2024
36632ce
Add lower incomplete gamma function approximation and use it in integ…
trontrytel Aug 21, 2024
1a860ea
added time integrator mixed phase test
Aug 20, 2024
33982d9
fixed citation key
Sep 9, 2024
89940de
fixed noneq gpu test
Sep 9, 2024
675fc35
trying to fix IR issues
Sep 9, 2024
ef8a564
fixed gpu type instability
Sep 16, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
set correct values for smoke tests
  • Loading branch information
Olivia Alcabes committed Aug 20, 2024
commit acab4a46ada4a9db17604dcba240a52985f7a165
4 changes: 2 additions & 2 deletions test/microphysics_noneq_tests.jl
Original file line number Diff line number Diff line change
@@ -115,8 +115,8 @@ function test_microphysics_noneq(FT)
TT.@test CMNe.conv_q_vap_to_q_liq_ice_MM2015_timeintegrator(liquid, ice, tps, qₚ( qᵥ_si), ρ, T, w, p_air, const_dt, "deposition") ≈ FT(0)

# smoke test for values
TT.@test CMNe.conv_q_vap_to_q_liq_ice_MM2015_timeintegrator(liquid, ice, tps, qₚ(FT(1.2 * qᵥ_sl)), ρ, T, w, p_air, const_dt, "condensation") ≈ 9.0419475e-5 rtol = 1e-6
TT.@test CMNe.conv_q_vap_to_q_liq_ice_MM2015_timeintegrator(liquid, ice, tps, qₚ(FT(1.2 * qᵥ_si)), ρ, T, w, p_air, const_dt, "deposition") ≈ 8.627814e-5 rtol = 1e-6
TT.@test CMNe.conv_q_vap_to_q_liq_ice_MM2015_timeintegrator(liquid, ice, tps, qₚ(FT(1.2 * qᵥ_sl)), ρ, T, w, p_air, const_dt, "condensation") ≈ 3.7177455f-5 rtol = 1e-6
TT.@test CMNe.conv_q_vap_to_q_liq_ice_MM2015_timeintegrator(liquid, ice, tps, qₚ(FT(1.2 * qᵥ_si)), ρ, T, w, p_air, const_dt, "deposition") ≈ 3.2125972f-5 rtol = 1e-6

# ice grows faster than liquid
TT.@test CMNe.conv_q_vap_to_q_liq_ice_MM2015_timeintegrator(liquid, ice, tps, qₚ(FT(1.2 * qᵥ_sl)), ρ, T, w, p_air, const_dt, "condensation") <