Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ONT parser from JSON to HTML #519

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Change ONT parser from JSON to HTML #519

merged 1 commit into from
Aug 21, 2024

Conversation

Karl-Svard
Copy link
Collaborator

Changed

  • Modified the JSON file parser to read in the HTML report instead.
  • Updated parser functions accordingly.

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@Karl-Svard
Copy link
Collaborator Author

Tested on stage:

Screenshot 2024-08-21 at 11 43 38

Copy link
Contributor

@idalindegaard idalindegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@Karl-Svard Karl-Svard merged commit 6615783 into master Aug 21, 2024
2 checks passed
@Karl-Svard Karl-Svard deleted the ont_html_parser branch August 21, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants