Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize and rename buffer aliquotation script used in the Sample Placement step in several LIMS workflows #534

Merged
merged 7 commits into from
Sep 25, 2024

Conversation

idalindegaard
Copy link
Contributor

Added

Changed

  • Re-named calculate-water to calculate-buffer
  • Re-named main function from volume_water to volume_buffer
  • Added new CLI flags for specifying UDF names for volumes

Fixed

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@idalindegaard idalindegaard changed the title Generalize and rename buffer aliquotation script used in Sample Placement Generalize and rename buffer aliquotation script used in the Sample Placement step in several LIMS workflows Sep 25, 2024
@idalindegaard
Copy link
Contributor Author

idalindegaard commented Sep 25, 2024

When specifying the volume UDFs as CLI flags, the script worked for different buffer cases, see example below:

In Sample placement for the WGS Watchmaker workflow:

lims -c <config> -l <log> -p <process> udf calculate volume-buffer -svl 50 -v 'Sample Volume (ul)' -b 'EB Volume (ul)' --total-volume-udf 'Total Volume (uL)'
Screenshot 2024-09-25 at 15 28 47
In Sample placement for the TWIST workflow:
lims -c <config> -l <log> -p <process> udf calculate volume-buffer -svl 50 -v 'Sample Volume (ul)' -b 'Volume H2O (ul)' --total-volume-udf 'Total Volume (uL)'
Screenshot 2024-09-25 at 15 28 01

Copy link
Collaborator

@Karl-Svard Karl-Svard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🔥

@idalindegaard idalindegaard merged commit a11ff4c into master Sep 25, 2024
2 checks passed
@idalindegaard idalindegaard deleted the generalize_calculate_water branch September 25, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants