Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Novaseq X volume constants #561

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Conversation

idalindegaard
Copy link
Contributor

@idalindegaard idalindegaard commented Nov 22, 2024

A patch after the change in issue #522

Added

  • new denaturation volume constants in constants.py
  • updated which constants to use in novaseq_x_denaturation.py

Changed

Fixed

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@idalindegaard
Copy link
Contributor Author

idalindegaard commented Nov 25, 2024

Testing on stage:

Expected result

We want the Adjusted Bulk Pool Volume (ul) in step Define Run Format and Calculate Volumes (NovaSeq X) to be 35 ul as a minimum volume per lane for 1.5B and 10B flowcells, and 57 ul per lane for a 25B flowcell. In step Make Pool and Denature (NovaSeq X) the Total Volume of Pool to Denature (ul) should reflect the value of Adjusted Bulk Pool Volume (ul) in the previous step, while Volume of Pool to Denature (ul) per Lane should be 34 ul for 1.5B and 10B flowcells, and 56 ul for a 25B flowcell, (the actual pipetting volume).

Result

1.5B flowcell for 1 lane:
Screenshot 2024-11-22 at 15 45 32
Screenshot 2024-11-25 at 09 50 26

10B flowcell for 1 lane:
Screenshot 2024-11-22 at 15 36 18
Screenshot 2024-11-25 at 09 52 08

25B flowcell for 1 lane:
Screenshot 2024-11-22 at 15 42 58
Screenshot 2024-11-25 at 09 53 02

10B flowcell for 8 lanes
Screenshot 2024-11-25 at 09 54 51
Screenshot 2024-11-25 at 10 32 30

Conclusion:

Expected result was achieved.

Copy link
Collaborator

@Karl-Svard Karl-Svard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@idalindegaard idalindegaard merged commit 8146d09 into master Nov 25, 2024
2 checks passed
@idalindegaard idalindegaard deleted the new_novaseqx_pooling_constants branch November 25, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants