Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume as process udf to calculate amount #577

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

idalindegaard
Copy link
Contributor

Added

  • The option to calculate the amount with the volume as a process udf in the step

Changed

Fixed

Steps to consider while deploying

  • Configuration changes:
  • Documentation updates:
  • Inform users by email:

Review:

  • Code approved by
  • Tests executed on stage by: (Document the test done with screen shots and description.)
  • "Merge and deploy" approved by

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Copy link
Collaborator

@Karl-Svard Karl-Svard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

cg_lims/EPPs/udf/calculate/calculate_amount_ng.py Outdated Show resolved Hide resolved
cg_lims/EPPs/udf/calculate/calculate_amount_ng.py Outdated Show resolved Hide resolved
@idalindegaard
Copy link
Contributor Author

Testing on stage

EPP: Calculate Amount after SRE

bash -c -l "conda activate cg_lims &&  lims -c /home/glsai/.genologics.yaml epps -l {compoundOutputFileLuid0} -p {processLuid}  udf calculate calculate-amount-ng --concentration-udf 'Concentration' --amount-udf 'Amount (ng)' --volume-udf 'Volume (ul)' --total-volume-pudf 'Elution Volume (ul)' --subtract-volume 0"

Works as intended, if no volume is given the script gives an error message (I will make the process udf "Elution Volume (ul)" required for the future)
Screenshot 2025-01-16 at 15 21 06
Screenshot 2025-01-16 at 15 49 13

EPP: Calculate Amount Revio (for measurement)
Just to check that a configuration where an artifact Volume (ul) udf is used works as normal

bash -c -l "conda activate cg_lims &&  lims -c /home/glsai/.genologics.yaml epps -l {compoundOutputFileLuid0} -p {processLuid}  udf calculate calculate-amount-ng --concentration-udf 'Concentration' --amount-udf 'Amount (ng)' --volume-udf 'Volume (ul)' --subtract-volume 2 -m"

Works as intended
Screenshot 2025-01-16 at 15 50 55

EPP: Calculate Amount after SRE (preset 75)
Just to check that a configuration with a preset volume is used as normal

bash -c -l "conda activate cg_lims &&  lims -c /home/glsai/.genologics.yaml epps -l {compoundOutputFileLuid0} -p {processLuid}  udf calculate calculate-amount-ng --concentration-udf 'Concentration' --amount-udf 'Amount (ng)' --volume-udf 'Volume (ul)' --subtract-volume 0 --preset-volume 75"

Works as intended
Screenshot 2025-01-16 at 15 52 55

@idalindegaard idalindegaard merged commit e6c8813 into master Jan 16, 2025
2 checks passed
@idalindegaard idalindegaard deleted the update_calculate_amount branch January 16, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants