Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database choice #49

Closed
wants to merge 3 commits into from
Closed

database choice #49

wants to merge 3 commits into from

Conversation

tijeco
Copy link

@tijeco tijeco commented May 27, 2022

Database choice

The current version doesn't seem to necessarily allow for choosing which database to download / use as mentioned in #48 , so I have drafted this PR.

My goal is that the database used would be explicitly declared, so each database has its own flag added to the arguments.json file for run and download. The idea being that to just download mitelman, you could run fusion_report download --use_mitelman true database_output if you just wanted to download that one database, or any combination of --use_cosmic, --use_mitelman, --use_fusiongdb and --use_fusiongdb2. For my purposes, I only wanted to download mitelman, fusiongdb and fusiongdb2. So I can now run the following:

fusion_report download  --use_mitelman true --use_fusiongdb true --use_fusiongdb2 true fusionreport_download

Further, to run on the test dataset, I can use the following:

fusion_report run "test" test_output fusionreport_download/ \
  --use_mitelman true --use_fusiongdb true --use_fusiongdb2 true \
  --arriba tests/test_data/arriba.tsv \
  --dragen tests/test_data/dragen.tsv \
  --ericscript tests/test_data/ericscript.tsv \
  --fusioncatcher tests/test_data/fusioncatcher.txt \
  --pizzly tests/test_data/pizzly.tsv \
  --squid tests/test_data/squid.txt \
  --starfusion tests/test_data/starfusion.tsv \
  --jaffa tests/test_data/jaffa.csv \
  --allow-multiple-gene-symbols

I also included a conda environment file, which I included as I used it with a jupyter notebook to play around with the library, so I thought it might be useful as well.

Let me know what you think.

Checklist

  • Specify in detail the change
  • Make sure to follow guidelines in docs when adding database/tool
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README is updated

@matq007
Copy link
Collaborator

matq007 commented Jun 9, 2022

Hi @tijeco, I understand why would you prefer to choose your own databases. We made it initially with idea of using all of them because otherwise you have to specify a weight for each database separately.

@rannick
Copy link
Collaborator

rannick commented Oct 4, 2024

It is really nice, I implemented similar options, just from the negative, so you would need to specify the databases you don't want instead of the ones you want.

@rannick
Copy link
Collaborator

rannick commented Oct 4, 2024

#77

@rannick rannick closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants