Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database choice
The current version doesn't seem to necessarily allow for choosing which database to download / use as mentioned in #48 , so I have drafted this PR.
My goal is that the database used would be explicitly declared, so each database has its own flag added to the
arguments.json
file for run and download. The idea being that to just download mitelman, you could runfusion_report download --use_mitelman true database_output
if you just wanted to download that one database, or any combination of--use_cosmic
,--use_mitelman
,--use_fusiongdb
and--use_fusiongdb2
. For my purposes, I only wanted to download mitelman, fusiongdb and fusiongdb2. So I can now run the following:Further, to run on the test dataset, I can use the following:
I also included a conda environment file, which I included as I used it with a jupyter notebook to play around with the library, so I thought it might be useful as well.
Let me know what you think.
Checklist
docs
when adding database/tooldocs
is updatedCHANGELOG.md
is updatedREADME
is updated