Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom gemfile #889

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow custom gemfile #889

wants to merge 1 commit into from
+21 −3

Conversation

mirecheck
Copy link
Collaborator

No description provided.

@mirecheck mirecheck requested a review from tomjelinek as a code owner November 7, 2024 15:56
@mirecheck mirecheck force-pushed the allow-custom-gemfile branch from f0ac637 to 2d5a334 Compare November 18, 2024 11:27
tomjelinek
tomjelinek requested changes Dec 10, 2024
View reviewed changes
Copy link
Member

@tomjelinek tomjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behavior should be controlled by a switch passed to configure script. When it's controlled by the presence of a file, it is rather nontransparent and nonintuitive.

@mirecheck mirecheck force-pushed the allow-custom-gemfile branch from 2d5a334 to d1f63c3 Compare January 7, 2025 14:57
@mirecheck mirecheck force-pushed the allow-custom-gemfile branch from d1f63c3 to a4d1cf7 Compare January 7, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomjelinek tomjelinek tomjelinek requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mirecheck @tomjelinek