Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom power scaling #21

Open
wants to merge 2 commits into
base: 1.12
Choose a base branch
from
Open

Add custom power scaling #21

wants to merge 2 commits into from

Conversation

Phlosioneer
Copy link

The custom power scaling configuration behaves the same as in thermal expansion.

The defaults have been chosen such that all costs stay the same, except that the sickle now costs 1,600RF in empowered mode instead of 1,200RF.

I tried my best to maintain the same code style as the rest of the cofh mods.

I was not able to figure out how to comiple this mod, so I couldn't test my changes, or even confirm that it compiles. I checked my code over several times to try and spot any issues that may occur.

I am open to alternate implementation ideas or changes; I mostly wanted a way to scale the power cost from 200RF to 3,000RF per use. You are welcome to push to my branch if you want to.

The custom power scaling configuration behaves the same as in thermal
expansion.

The defaults have been chosen such that all costs stay the same, except
that the sickle now costs 1,600RF in empowered mode instead of 1,200RF.
Forgot about the armor folder!
@Phlosioneer
Copy link
Author

From testing (via bytecode patching, still can't actually compile this), I've noticed that not all classes derive from ItemToolFlux, so I have some additional work to do. I've also noticed that some tool classes overwrite the charged power with redundant values (pickaxe and shovel), so I need to remove those extraneous assignments. I also completely forgot about the quiver.

Tomorrow I'll push updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant