Django update to 5.0 #195
Merged
Django update to 5.0 #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tomolopolis
commented
Jun 18, 2024
tomolopolis
commented
- Have tested an updated Django 5.0 build locally fairly extensively. This should be tested well on CREATE before being released.
|
deployed and tested on CREATE. Django >4.0 requires CSRF_ORIGINS in |
…or vocab of an uploaded model pack are deleted first instead of the model pack being deleted
|
LGTM |
adam-sutton-1992
approved these changes
Jul 3, 2024
tomolopolis
commented
Jul 3, 2024
| @@ -24,11 +24,13 @@ | |||
| <p>{{selectedProjectGroup.description}}</p> | |||
| </div> | |||
| <div slot="body"> | |||
| <project-list :project-items="selectedProjectGroup.items" :is-admin="isAdmin"></project-list> | |||
| <project-list :project-items="selectedProjectGroup.items" :is-admin="isAdmin" | |||
There was a problem hiding this comment.
Fix that should have been in PR #190
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.