Prevent closing app while doing critical process

[bagusnl]

Main Goal

Show dialog confirming user before exiting app while critical process is happening

Close #671

Currently implemented in:

• Game Install
• Game Update
• Cache Update
• Game Repair

PR Status :

• Overall Status : Done
• Commits : Done
• Synced to base (Collapse:main) : Yes
• Build status : OK
• Crashing : No
• Bug found caused by PR : 0

Sidenote:

• Bug found when making this PR, unrelated to the PR itself
  When closing app while some UI progress is happening, there is a chance that it throws bunch of errors on XAML thread before it exit
  

Templates

Changelog Prefixes

  **[New]**
  **[Imp]**
  **[Fix]**
  **[Loc]**
  **[Doc]**

[bagusnl]

Need consultation about this @neon-nyan

is it safe to return Task for the Close method instead, making it detached?

[github-actions]

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[neon-nyan]

Need consultation about this @neon-nyan

is it safe to return Task for the Close method instead, making it detached?

IMO, it should be safe to use Task for the CloseApp() method and running it detached.
The thing to consider is that, since Task should always be awaited and by running it detached, it will give a warning.
To get rid of that, you can use something like this everytime you call the method:

_ = CloseApp();

[bagusnl]

Need consultation about this @neon-nyan

is it safe to return Task for the Close method instead, making it detached?

IMO, it should be safe to use Task for the CloseApp() method and running it detached. The thing to consider is that, since Task should always be awaited and by running it detached, it will give a warning. To get rid of that, you can use something like this everytime you call the method:

_ = CloseApp();

dune tank!

[neon-nyan]

Just one review for the overall changes. Others are looking good to me

[bagusnl]

Ready to merge!

[sonarqubecloud]

Quality Gate failed

Failed conditions
4.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud