Extract errors constructors into single private method

CommerceWeavers · Jun 14, 2023 · 7e64d8b · 7e64d8b
1 parent 41b7455
commit 7e64d8b
Showing 1 changed file with 23 additions and 42 deletions.
diff --git a/src/Client/ValueObject/ErrorResponse.php b/src/Client/ValueObject/ErrorResponse.php
@@ -27,60 +27,22 @@ private function __construct(
 
     public static function forAssert(array $data): self
     {
-        return new self(
-            $data['StatusCode'],
-            ResponseHeader::fromArray($data['ResponseHeader']),
-            $data['ErrorName'],
-            $data['ErrorMessage'],
-            [],
-            $data['Behavior'],
-            'Assert',
-            $data['TransactionId'],
-            $data['OrderId'],
-            $data['PayerMessage'] ?? null,
-        );
+        return self::createForOperation($data, 'Assert');
     }
 
     public static function forCapture(array $data): self
     {
-        return new self(
-            $data['StatusCode'],
-            ResponseHeader::fromArray($data['ResponseHeader']),
-            $data['ErrorName'],
-            $data['ErrorMessage'],
-            [],
-            $data['Behavior'],
-            'Capture',
-        );
+        return self::createForOperation($data, 'Capture');
     }
 
     public static function forAuthorize(array $data): self
     {
-        return new self(
-            $data['StatusCode'],
-            ResponseHeader::fromArray($data['ResponseHeader']),
-            $data['ErrorName'],
-            $data['ErrorMessage'],
-            $data['ErrorDetail'] ?? [],
-            $data['Behavior'],
-            'Authorize',
-            $data['TransactionId'] ?? null,
-            $data['OrderId'] ?? null,
-            $data['PayerMessage'] ?? null,
-        );
+        return self::createForOperation($data, 'Authorize');
     }
 
     public static function forRefund(array $data): self
     {
-        return new self(
-            $data['StatusCode'],
-            ResponseHeader::fromArray($data['ResponseHeader']),
-            $data['ErrorName'],
-            $data['ErrorMessage'],
-            [],
-            $data['Behavior'],
-            'Refund',
-        );
+        return self::createForOperation($data, 'Refund');
     }
 
     public function getStatusCode(): int
@@ -170,4 +132,23 @@ public function isSuccessful(): bool
     {
         return false;
     }
+
+    private static function createForOperation(array $data, string $operation): self
+    {
+        return new self(
+            $data['StatusCode'],
+            ResponseHeader::fromArray($data['ResponseHeader']),
+            $data['ErrorName'],
+            $data['ErrorMessage'],
+            $data['ErrorDetail'] ?? [],
+            $data['Behavior'],
+            $operation,
+            $data['TransactionId'] ?? null,
+            $data['OrderId'] ?? null,
+            $data['PayerMessage'] ?? null,
+            $data['ProcessorName'] ?? null,
+            $data['ProcessorResult'] ?? null,
+            $data['ProcessorMessage'] ?? null,
+        );
+    }
 }