disable outgroup computation for pangenomes #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that
compute_outgroups()uses quadratic memory in the size of the tree, I guess for a big distance matrix. This has never been an issue for progressive cactus, but as I'm testing making pangenomes with tons of small inputs it's now a bottleneck.This PR just disables outgroup computation for pangenomes (they aren't used at all anyway). But at some point it'd be good to revise things so that outgroup computation can work without the full matrix in memory...
Note, this means #1043 will need updating to add more nuanced control / a better fix.