Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defined notes for BSI SYS.1.6.A15 #12528

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

lichtblaugue
Copy link

Description:

Adding serveral existing rules and one manual rule for checking this requirement.

Rationale:

As we have multiple customers asking for a BSI profile to be included in the compliance-operator, we are contributing a profile. To provide a better review process, the individual controle are implemented as separate PRs.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Oct 23, 2024
Copy link

openshift-ci bot commented Oct 23, 2024

Hi @lichtblaugue. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

ocp4 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
New content has different text for rule 'xccdf_org.ssgproject.content_rule_project_config_and_template_resource_quota'.
--- xccdf_org.ssgproject.content_rule_project_config_and_template_resource_quota
+++ xccdf_org.ssgproject.content_rule_project_config_and_template_resource_quota
@@ -47,6 +47,9 @@
 SRG-APP-000435-CTR-001070
 
 [reference]:
+SYS.1.6.A15
+
+[reference]:
 CNTR-OS-000620
 
 [reference]:

New content has different text for rule 'xccdf_org.ssgproject.content_rule_project_template_resource_quota'.
--- xccdf_org.ssgproject.content_rule_project_template_resource_quota
+++ xccdf_org.ssgproject.content_rule_project_template_resource_quota
@@ -32,6 +32,9 @@
 [reference]:
 SRG-APP-000246-CTR-000605
 
+[reference]:
+SYS.1.6.A15
+
 [rationale]:
 Running different applications on the same Kubernetes cluster creates a risk of 
 a "noisy neighbor" when one application monopolizes cluster resources.

New content has different text for rule 'xccdf_org.ssgproject.content_rule_resource_requests_limits_in_daemonset'.
--- xccdf_org.ssgproject.content_rule_resource_requests_limits_in_daemonset
+++ xccdf_org.ssgproject.content_rule_resource_requests_limits_in_daemonset
@@ -26,6 +26,9 @@
 [reference]:
 SC-6
 
+[reference]:
+SYS.1.6.A15
+
 [rationale]:
 Resource requests/limits provide constraints that limit aggregate resource consumption
 per container. This helps prevent resource starvation. When deploying your

New content has different text for rule 'xccdf_org.ssgproject.content_rule_resource_requests_limits_in_deployment'.
--- xccdf_org.ssgproject.content_rule_resource_requests_limits_in_deployment
+++ xccdf_org.ssgproject.content_rule_resource_requests_limits_in_deployment
@@ -26,6 +26,9 @@
 [reference]:
 SC-6
 
+[reference]:
+SYS.1.6.A15
+
 [rationale]:
 Resource requests/limits provide constraints that limit aggregate resource consumption
 per container. This helps prevent resource starvation. When deploying your

New content has different text for rule 'xccdf_org.ssgproject.content_rule_resource_requests_limits_in_statefulset'.
--- xccdf_org.ssgproject.content_rule_resource_requests_limits_in_statefulset
+++ xccdf_org.ssgproject.content_rule_resource_requests_limits_in_statefulset
@@ -26,6 +26,9 @@
 [reference]:
 SC-6
 
+[reference]:
+SYS.1.6.A15
+
 [rationale]:
 Resource requests/limits provide constraints that limit aggregate resource consumption
 per container. This helps prevent resource starvation. When deploying your

New content has different text for rule 'xccdf_org.ssgproject.content_rule_resource_requests_quota'.
--- xccdf_org.ssgproject.content_rule_resource_requests_quota
+++ xccdf_org.ssgproject.content_rule_resource_requests_quota
@@ -57,6 +57,9 @@
 [reference]:
 SC-5(2)
 
+[reference]:
+SYS.1.6.A15
+
 [rationale]:
 Resource quotas provide constraints that limit aggregate resource consumption 
 per project. This helps prevent resource starvation. When deploying your 

New content has different text for rule 'xccdf_org.ssgproject.content_rule_resource_requests_quota_cluster'.
--- xccdf_org.ssgproject.content_rule_resource_requests_quota_cluster
+++ xccdf_org.ssgproject.content_rule_resource_requests_quota_cluster
@@ -45,6 +45,9 @@
 [reference]:
 SC-5(2)
 
+[reference]:
+SYS.1.6.A15
+
 [rationale]:
 Resource quotas provide constraints that limit aggregate resource consumption 
 per project. This helps prevent resource starvation. When deploying your 

New content has different text for rule 'xccdf_org.ssgproject.content_rule_resource_requests_quota_per_project'.
--- xccdf_org.ssgproject.content_rule_resource_requests_quota_per_project
+++ xccdf_org.ssgproject.content_rule_resource_requests_quota_per_project
@@ -64,6 +64,9 @@
 SRG-APP-000450-CTR-001105
 
 [reference]:
+SYS.1.6.A15
+
+[reference]:
 CNTR-OS-000620
 
 [reference]:

@jan-cerny jan-cerny added the OpenShift OpenShift product related. label Oct 25, 2024
Copy link

codeclimate bot commented Nov 6, 2024

Code Climate has analyzed commit 22df150 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

@yuumasato
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Nov 28, 2024
@yuumasato yuumasato self-assigned this Nov 28, 2024
@yuumasato yuumasato added this to the 0.1.76 milestone Nov 28, 2024
Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yuumasato
Copy link
Member

/test 4.17-e2e-aws-ocp4-bsi
/test 4.17-e2e-aws-ocp4-bsi-node
/test 4.17-e2e-aws-rhcos4-bsi

Copy link

openshift-ci bot commented Nov 28, 2024

@lichtblaugue: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.17-e2e-aws-ocp4-bsi 22df150 link true /test 4.17-e2e-aws-ocp4-bsi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@yuumasato
Copy link
Member

Failures in resource-requests-quota-cluster and resource-requests-quota-per-project are not relevant.
The rule was updated recently but the rule asssertion files were not.

@yuumasato yuumasato merged commit e247115 into ComplianceAsCode:master Nov 29, 2024
95 of 104 checks passed
@sluetze sluetze deleted the sys-1-6-A15 branch December 2, 2024 16:18
@yuumasato yuumasato added the BSI PRs or issues for the BSI profile. label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSI PRs or issues for the BSI profile. ok-to-test Used by openshift-ci bot. OpenShift OpenShift product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants