-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defined notes for BSI SYS.1.6.A15 #12528
Defined notes for BSI SYS.1.6.A15 #12528
Conversation
Hi @lichtblaugue. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This datastream diff is auto generated by the check Click here to see the full diffNew content has different text for rule 'xccdf_org.ssgproject.content_rule_project_config_and_template_resource_quota'.
--- xccdf_org.ssgproject.content_rule_project_config_and_template_resource_quota
+++ xccdf_org.ssgproject.content_rule_project_config_and_template_resource_quota
@@ -47,6 +47,9 @@
SRG-APP-000435-CTR-001070
[reference]:
+SYS.1.6.A15
+
+[reference]:
CNTR-OS-000620
[reference]:
New content has different text for rule 'xccdf_org.ssgproject.content_rule_project_template_resource_quota'.
--- xccdf_org.ssgproject.content_rule_project_template_resource_quota
+++ xccdf_org.ssgproject.content_rule_project_template_resource_quota
@@ -32,6 +32,9 @@
[reference]:
SRG-APP-000246-CTR-000605
+[reference]:
+SYS.1.6.A15
+
[rationale]:
Running different applications on the same Kubernetes cluster creates a risk of
a "noisy neighbor" when one application monopolizes cluster resources.
New content has different text for rule 'xccdf_org.ssgproject.content_rule_resource_requests_limits_in_daemonset'.
--- xccdf_org.ssgproject.content_rule_resource_requests_limits_in_daemonset
+++ xccdf_org.ssgproject.content_rule_resource_requests_limits_in_daemonset
@@ -26,6 +26,9 @@
[reference]:
SC-6
+[reference]:
+SYS.1.6.A15
+
[rationale]:
Resource requests/limits provide constraints that limit aggregate resource consumption
per container. This helps prevent resource starvation. When deploying your
New content has different text for rule 'xccdf_org.ssgproject.content_rule_resource_requests_limits_in_deployment'.
--- xccdf_org.ssgproject.content_rule_resource_requests_limits_in_deployment
+++ xccdf_org.ssgproject.content_rule_resource_requests_limits_in_deployment
@@ -26,6 +26,9 @@
[reference]:
SC-6
+[reference]:
+SYS.1.6.A15
+
[rationale]:
Resource requests/limits provide constraints that limit aggregate resource consumption
per container. This helps prevent resource starvation. When deploying your
New content has different text for rule 'xccdf_org.ssgproject.content_rule_resource_requests_limits_in_statefulset'.
--- xccdf_org.ssgproject.content_rule_resource_requests_limits_in_statefulset
+++ xccdf_org.ssgproject.content_rule_resource_requests_limits_in_statefulset
@@ -26,6 +26,9 @@
[reference]:
SC-6
+[reference]:
+SYS.1.6.A15
+
[rationale]:
Resource requests/limits provide constraints that limit aggregate resource consumption
per container. This helps prevent resource starvation. When deploying your
New content has different text for rule 'xccdf_org.ssgproject.content_rule_resource_requests_quota'.
--- xccdf_org.ssgproject.content_rule_resource_requests_quota
+++ xccdf_org.ssgproject.content_rule_resource_requests_quota
@@ -57,6 +57,9 @@
[reference]:
SC-5(2)
+[reference]:
+SYS.1.6.A15
+
[rationale]:
Resource quotas provide constraints that limit aggregate resource consumption
per project. This helps prevent resource starvation. When deploying your
New content has different text for rule 'xccdf_org.ssgproject.content_rule_resource_requests_quota_cluster'.
--- xccdf_org.ssgproject.content_rule_resource_requests_quota_cluster
+++ xccdf_org.ssgproject.content_rule_resource_requests_quota_cluster
@@ -45,6 +45,9 @@
[reference]:
SC-5(2)
+[reference]:
+SYS.1.6.A15
+
[rationale]:
Resource quotas provide constraints that limit aggregate resource consumption
per project. This helps prevent resource starvation. When deploying your
New content has different text for rule 'xccdf_org.ssgproject.content_rule_resource_requests_quota_per_project'.
--- xccdf_org.ssgproject.content_rule_resource_requests_quota_per_project
+++ xccdf_org.ssgproject.content_rule_resource_requests_quota_per_project
@@ -64,6 +64,9 @@
SRG-APP-000450-CTR-001105
[reference]:
+SYS.1.6.A15
+
+[reference]:
CNTR-OS-000620
[reference]: |
applications/openshift/networking/configure_network_bandwidth/rule.yml
Outdated
Show resolved
Hide resolved
applications/openshift/networking/configure_network_bandwidth/rule.yml
Outdated
Show resolved
Hide resolved
applications/openshift/networking/configure_network_bandwidth/rule.yml
Outdated
Show resolved
Hide resolved
applications/openshift/networking/configure_network_bandwidth/rule.yml
Outdated
Show resolved
Hide resolved
applications/openshift/networking/configure_network_bandwidth/rule.yml
Outdated
Show resolved
Hide resolved
Code Climate has analyzed commit 22df150 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 60.9% (0.0% change). View more on Code Climate. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test 4.17-e2e-aws-ocp4-bsi |
@lichtblaugue: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Failures in |
Description:
Adding serveral existing rules and one manual rule for checking this requirement.
Rationale:
As we have multiple customers asking for a BSI profile to be included in the compliance-operator, we are contributing a profile. To provide a better review process, the individual controle are implemented as separate PRs.