Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix oval_feed_url for ubuntu products #12615

Closed
wants to merge 1 commit into from
Closed

Fix oval_feed_url for ubuntu products #12615

wants to merge 1 commit into from

Conversation

dodys
Copy link
Contributor

@dodys dodys commented Nov 15, 2024

Description:

@dodys dodys added the Ubuntu Ubuntu product related. label Nov 15, 2024
@dodys dodys requested a review from Mab879 November 15, 2024 18:34
@github-actions GitHub Actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate CodeClimate
Copy link

codeclimate bot commented Nov 15, 2024

Code Climate has analyzed commit afaf7bc and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 mentioned this pull request Nov 15, 2024
Merged
mpurg
mpurg reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@mpurg mpurg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see the PR in time and made a similar change: https://github.com/ComplianceAsCode/content/pull/12617/files

From what I can tell, the oval_feed_url var is supposed to link to the feed containing the list of security patches (rule security_patches_up_to_date), not list of vulnerabilities, so maybe the USN feed is more appropriate?

The product stability files should be updated too I believe.

@mpurg mpurg mentioned this pull request Nov 18, 2024
Merged
@dodys
Copy link
Contributor Author

dodys commented Nov 18, 2024

closing this for PR #12617

@dodys dodys closed this Nov 18, 2024
@dodys dodys deleted the oval_feed_url branch November 18, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpurg mpurg mpurg left review comments

@Mab879 Mab879 Awaiting requested review from Mab879

Assignees
No one assigned
Labels
Ubuntu Ubuntu product related.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dodys @mpurg