Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump OpenSCAP Version for Windows Tests #12798

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

Mab879
Copy link
Member

@Mab879 Mab879 commented Jan 9, 2025

Description:

1.4.1 -> 1.4.2 since we using latest master for the build.

Rationale:

Make CI green

Review Hints:

Make sure the Windows gating tests pass.

@Mab879 Mab879 added the Infrastructure Our content build system label Jan 9, 2025
@Mab879 Mab879 added this to the 0.1.76 milestone Jan 9, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Jan 9, 2025
Copy link

openshift-ci bot commented Jan 9, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@Mab879 Mab879 marked this pull request as ready for review January 9, 2025 14:54
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Jan 9, 2025

Code Climate has analyzed commit b56fc9a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.6% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny self-assigned this Jan 9, 2025
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Build on Windows" CI jobs passed on I have seen that it uses OpenSCAP bersion 1.4.2 ofor the content build.

@Mab879
Copy link
Member Author

Mab879 commented Jan 9, 2025

/packit retest-failed

2 similar comments
@Mab879
Copy link
Member Author

Mab879 commented Jan 9, 2025

/packit retest-failed

@Mab879
Copy link
Member Author

Mab879 commented Jan 9, 2025

/packit retest-failed

@marcusburghardt
Copy link
Member

We should be fine to merge it now @jan-cerny

Gate / Build, Test on Ubuntu 24.04 (pull_request) should be addressed by #12796

@marcusburghardt marcusburghardt self-assigned this Jan 10, 2025
@marcusburghardt marcusburghardt merged commit 4f13509 into ComplianceAsCode:master Jan 10, 2025
105 of 106 checks passed
@Mab879 Mab879 deleted the fix_openscap141 branch January 10, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants