-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add crusher profile, update spock profile, update openPMD-api doc #3964
Add crusher profile, update spock profile, update openPMD-api doc #3964
Conversation
Regarding openPMD API, does the old version not work with C++17? |
d15949b
to
3aab315
Compare
No, I tried to use 0.13.4 as it is provided as a module, but received an error that at least 0.14.3 is required. |
Ah true, so our cmake requests what it should, just docs were not updated. Thanks for fixing |
@steindev The CI failed - seems to be caused by the CI - I will restart the CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but I did not test it.
INSTALL.rst
Outdated
@@ -281,7 +281,7 @@ openPMD API | |||
- environment:* (assumes install from source in ``$HOME/lib/openPMD-api``) | |||
|
|||
- ``export CMAKE_PREFIX_PATH="$HOME/lib/openPMD-api:$CMAKE_PREFIX_PATH"`` | |||
- ``export LD_LIBRARY_PATH="$HOME/lib/openPMD-api/lib:$LD_LIBRARY_PATH"`` | |||
- ``export LD_LIBRARY_PATH="$HOME/lib/openPMD-api/lib64:$LD_LIBRARY_PATH"`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is platform-specific whether the shared library is installed under lib
or lib64
.
- ``export LD_LIBRARY_PATH="$HOME/lib/openPMD-api/lib64:$LD_LIBRARY_PATH"`` | |
- ``export LD_LIBRARY_PATH="$HOME/lib/openPMD-api/lib64:$HOME/lib/openPMD-api/lib:$LD_LIBRARY_PATH"`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great suggestion! Will include.
We fixed an ABI incompatibility with openPMD-api 0.14.3 openPMD/openPMD-api#1121 |
Set minimum version to 0.14.3 due to switch to C++17 and update path to lib folder in openPMD-api.
3aab315
to
9db5664
Compare
Adding a profile for crusher@OLCF.
While setting up PIConGPU for crusher@OLCF, I also saw that the modules on spock@OLCF changed and updated accordingly.
This is a separate commit.
Further, with changing to C++17 in dev we forgot to update our openPMD-api dependency section in the manual.
This is fixed in another separate commit, too.
However, it is part of this PR as the openPMD-api installation procedure in the docs is referred to in both profiles added/updated with this PR.
PIConGPU KHI example compiles and runs with openPMD output on crusher with this profile.
It compiles and runs without openPMD output on spock with this profile.
While compiling with openPMD output works on spock, running produces an
hipErrorOutOfMemory
when using ADIOS2 and HDF5 directly at start-up.Will need to further investigate. (Since I am not allows to use more than 28GiB per MI250X GCD on crusher and an MI100 on spock has 32GiB, I know that the setup itself is not too large, so something else must be going on.)
However, this is independent of this PR in my opinion.