Allow volumes to not be managed by Magic Castle (instead, use existing ones) #339
+48
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR fixes #326 |
mboisson
changed the title
|
Not sure why the first test fails. Seems to be unrelated (terraform command not found) |
mboisson
force-pushed
the
volume_attachments
branch
from
e74f90b to
547e07b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the volumes define
Then Terraform will not create or destroy the volumes. It will instead attempt to fetch pre-existing volumes that follow the naming convention (
<cluster name>-<node name>-<volume name>, i.e.testy-mgmt1-home), and mount these volumes in the instance. Puppet will then handle the volumes as if it were created by Terraform: from a blank volume, it will create the filesystem, while from a preconfigured volume, it will just stay as is.