-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trim the transaction table #1061
Conversation
pending transactions.
concordium-consensus/src/Concordium/GlobalState/Persistent/BlockState.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/KonsensusV1/Transactions.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/Persistent/TreeState.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/KonsensusV1/TreeState/Implementation.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/KonsensusV1/TreeState/Implementation.hs
Show resolved
Hide resolved
concordium-consensus/src/Concordium/KonsensusV1/TreeState/Implementation.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/TransactionTable.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/Persistent/TreeState.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/TransactionTable.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/Persistent/BlockState.hs
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/Persistent/TreeState.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/Persistent/TreeState.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/PurgeTransactions.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/TransactionTable.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/TransactionTable.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/TransactionTable.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/KonsensusV1/TreeState/Implementation.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/KonsensusV1/TreeState/Implementation.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/Persistent/BlockState.hs
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/PurgeTransactions.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/TransactionTable.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/KonsensusV1/TreeState/Implementation.hs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor things. Otherwise, ensure that the account nonce is re-checked before adding incoming transactions (not from blocks), per our discussion.
concordium-consensus/src/Concordium/GlobalState/TransactionTable.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/TransactionTable.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/KonsensusV1/TreeState/Implementation.hs
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/TransactionTable.hs
Outdated
Show resolved
Hide resolved
check on pre-verified transaction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Purpose
The
TransactionTable
and in particular non finalized transactions now only retains entries for accounts which have non-finalized transactions.Accounts without non-finalized transactions are expunged from the transaction table and in that case the last finalized block is used for keeping track of the next available account nonce.
Changes
Checklist
hard-to-understand areas.