Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove V1 grpc API. #1065

Merged
merged 10 commits into from
Nov 13, 2023
Merged

Remove V1 grpc API. #1065

merged 10 commits into from
Nov 13, 2023

Conversation

abizjak
Copy link
Contributor

@abizjak abizjak commented Nov 6, 2023

Purpose

Remove V1 API from the node.

Closes #1073

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

Copy link
Contributor

@MilkywayPirate MilkywayPirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I think at some point we should rename all the "grpc2" stuff to simply being "grpc". There is now only one and only one grpc api of the node, so it could end up being a bit confusing the future having this "v2"..

CHANGELOG.md Show resolved Hide resolved
concordium-node/build.rs Show resolved Hide resolved
@abizjak
Copy link
Contributor Author

abizjak commented Nov 12, 2023

I think at some point we should rename all the "grpc2" stuff to simply being "grpc". There is now only one and only one grpc api of the node, so it could end up being a bit confusing the future having this "v2"..

I am not convinced this is a good idea. It'll be more confusing and disruptive to do renaming. It's fairly easy to remember we used to have some other API.

@abizjak abizjak merged commit 1c2abd2 into main Nov 13, 2023
3 checks passed
@abizjak abizjak deleted the remove-v1 branch November 13, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove V1 GRPC API
3 participants