Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add protocol version 7 #1075

Merged
merged 4 commits into from
Nov 16, 2023
Merged

Add protocol version 7 #1075

merged 4 commits into from
Nov 16, 2023

Conversation

limemloh
Copy link
Contributor

@limemloh limemloh commented Nov 13, 2023 •
edited
Loading

Purpose

Add boilerplate for introducing a protocol version 7. Closing #1066.

Should be merged after Concordium/concordium-base#474 and Concordium/concordium-grpc-api#49.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

This was referenced Nov 13, 2023
Merged
Merged
@limemloh limemloh requested review from abizjak and td202 November 13, 2023 15:30
td202
td202 reviewed Nov 15, 2023
View reviewed changes
Copy link
Contributor

@td202 td202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see it here, but I think this PR should also add a P6->P7 protocol update (modelled on the P6 Reboot update). Some of the documentation issues in the new protocol update code may also be errors in the other places they've been copied from.

concordium-consensus/src/Concordium/GlobalState/Persistent/BlockState.hs Show resolved Hide resolved
concordium-consensus/src/Concordium/GlobalState/Persistent/Account/StructureV1.hs Outdated Show resolved Hide resolved
concordium-consensus/src/Concordium/ProtocolUpdate/P7/Reboot.hs Outdated Show resolved Hide resolved
concordium-consensus/src/Concordium/ProtocolUpdate/P7/Reboot.hs Outdated Show resolved Hide resolved
concordium-consensus/src/Concordium/ProtocolUpdate/P7/Reboot.hs Outdated Show resolved Hide resolved
@limemloh
Copy link
Contributor Author

I have now added the code for P6->P7 protocol update

@limemloh limemloh merged commit 2521cf7 into main Nov 16, 2023
3 checks passed
@limemloh limemloh deleted the add-protocol-v7 branch November 16, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MilkywayPirate MilkywayPirate MilkywayPirate approved these changes

@td202 td202 td202 approved these changes

@abizjak abizjak abizjak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@limemloh @abizjak @td202 @MilkywayPirate