-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run queries in dedicated threads #1101
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abizjak
changed the title
Run queries in blocking threads.
Run queries in dedicated threads
Jan 31, 2024
MilkywayPirate
approved these changes
Feb 1, 2024
Co-authored-by: Emil Lai <[email protected]>
td202
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Use a dedicated threadpool for running queries.
Since the queries call into Haskell it typically takes much more than 100us between await points. As a result there are problems with availability where queries pause for some time before resuming. The main reason for this seems to be that all the tokio workers are stuck in the "haskell code" so the scheduler cannot schedule other tasks, such as accepting connections, responding to requests, etc.
The guideline from tokio is that there should not be more than 10-100us in between await points.
(from one of the tokio developers https://ryhl.io/blog/async-what-is-blocking/ )
This is much less than the queries take typically (and queries can also block for a time due to locking).
Changes
This also allows limiting the resources the node is using for non-consensus related operations.
hyper
server. Without limiting this there seem to occassionally be some blocking issues as well where the queries end up doing nothing. The default value makes the node more robust in the default configuration.Checklist
hard-to-understand areas.