-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate new execution engine into the node. #1135
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abizjak
force-pushed
the
integrate-new-execution-engine
branch
from
March 30, 2024 14:38
fc54dff
to
14dfc0b
Compare
abizjak
force-pushed
the
integrate-new-execution-engine
branch
from
April 3, 2024 13:37
2a89188
to
0673c10
Compare
limemloh
approved these changes
Apr 4, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Integrate new execution engine into the node.
This does not change the protocol semantics yet, it simply integrates the new execution engine to execute existing contracts faster. There will be a followup PR which lowers the transaction costs at migration to P7.
The main change in this PR is handling of the new "artifacts". Since the artifacts are quite different, to avoid maintenance overhead, and to benefit from faster execution, the Wasm execution library only supports the new notion of artifacts. To deal with migration of existing artifacts for existing node runners the approach taken here is to recompile upon load of the artifact.
Since artifacts are cached and compiling to an artifact is mostly on the range of 5ms, with some being larger, this should be acceptable for existing node runners until P7 is in effect.
Depends on
Checklist
hard-to-understand areas.