Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate new execution engine into the node. #1135

Merged
merged 15 commits into from
Apr 21, 2024

Conversation

abizjak
Copy link
Contributor

@abizjak abizjak commented Mar 25, 2024

Purpose

Integrate new execution engine into the node.

This does not change the protocol semantics yet, it simply integrates the new execution engine to execute existing contracts faster. There will be a followup PR which lowers the transaction costs at migration to P7.

The main change in this PR is handling of the new "artifacts". Since the artifacts are quite different, to avoid maintenance overhead, and to benefit from faster execution, the Wasm execution library only supports the new notion of artifacts. To deal with migration of existing artifacts for existing node runners the approach taken here is to recompile upon load of the artifact.

Since artifacts are cached and compiling to an artifact is mostly on the range of 5ms, with some being larger, this should be acceptable for existing node runners until P7 is in effect.

Depends on

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@abizjak abizjak force-pushed the integrate-new-execution-engine branch from fc54dff to 14dfc0b Compare March 30, 2024 14:38
@abizjak abizjak requested review from limemloh and td202 March 30, 2024 19:27
@abizjak abizjak force-pushed the integrate-new-execution-engine branch from 2a89188 to 0673c10 Compare April 3, 2024 13:37
@abizjak abizjak merged commit 3f554a9 into main Apr 21, 2024
3 checks passed
@abizjak abizjak deleted the integrate-new-execution-engine branch April 21, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants