Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable encrypted transfers in P7. #1173

Merged
merged 4 commits into from
May 23, 2024
Merged

Disable encrypted transfers in P7. #1173

merged 4 commits into from
May 23, 2024

Conversation

td202
Copy link
Contributor

@td202 td202 commented May 15, 2024 •
edited
Loading

Purpose

Closes #1170

Disable encrypted transfers in protocol version 7. This is primarily done by decodePayload in concordium-base not allowing the relevant payload types to be deserialized in P7.

Changes

  • Update base.
  • decodePayload no longer takes payload length as a separate argument.
  • Disable encrypted transfer tests where they are no longer relevant.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@td202 td202 requested review from limemloh and eb-concordium May 15, 2024 13:43
@td202 td202 merged commit 6ba3eaa into main May 23, 2024
2 checks passed
@td202 td202 deleted the disable-encrypted branch May 23, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limemloh limemloh limemloh approved these changes

@eb-concordium eb-concordium eb-concordium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable encrypted transfers in P7
3 participants
@td202 @limemloh @eb-concordium