Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query fixes and refactoring #1209

Merged
merged 7 commits into from
Aug 12, 2024
Merged

Query fixes and refactoring #1209

merged 7 commits into from
Aug 12, 2024

Conversation

td202
Copy link
Contributor

@td202 td202 commented Aug 1, 2024

Purpose

Fixes #1176 - GetBakersRewardPeriod gives incorrect data
Fixes #1177 - GetPoolInfo reports incorrect commission rates

Changes

  • Base is updated. Some TODOs are inserted where support for AccountV3 is not implemented. The basic account release schedule for AccountV3 is defined the same as for AccountV2.
  • GetPassiveDelegationStatus is separated out from GetPoolStatus functionality.
  • getBakersRewardPeriod uses the "current payday" baker information
  • doGetPoolStatus is revised to get the correct information.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@td202 td202 requested review from drsk0 and eb-concordium August 1, 2024 14:26
@td202 td202 merged commit d82fcdd into main Aug 12, 2024
3 checks passed
@td202 td202 deleted the revise-get-pool-status branch August 12, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetPoolInfo returns incorrect commission rates for current payday GetBakersRewardPeriod gives incorrect data
3 participants