Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement migrate accountV3toV4 #1300

Merged
merged 1 commit into from
Dec 11, 2024
Merged

implement migrate accountV3toV4 #1300

merged 1 commit into from
Dec 11, 2024

Conversation

drsk0
Copy link
Contributor

@drsk0 drsk0 commented Dec 11, 2024

Purpose

Complete the migration from account v3 to v4. Closes #1221.

Changes

Adds migration paths for account v3 to v4.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

CLA acceptance

_Remove if not applicable.

By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

@drsk0 drsk0 requested a review from eb-concordium December 11, 2024 13:30
@drsk0 drsk0 force-pushed the migrate_account_v3_v4 branch 5 times, most recently from 570aeb8 to 3ba2503 Compare December 11, 2024 14:13
@drsk0 drsk0 marked this pull request as ready for review December 11, 2024 14:13
@drsk0 drsk0 force-pushed the migrate_account_v3_v4 branch from 3ba2503 to f2cfd52 Compare December 11, 2024 14:19
@drsk0 drsk0 force-pushed the migrate_account_v3_v4 branch from f2cfd52 to c91f26e Compare December 11, 2024 16:56
Copy link
Contributor

@eb-concordium eb-concordium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good to me

@drsk0 drsk0 merged commit 8907fab into main Dec 11, 2024
3 checks passed
@drsk0 drsk0 deleted the migrate_account_v3_v4 branch December 11, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement migrateV3ToV4 in Account/StructureV1.hs
2 participants