-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend ValidatorAdd with a suspended field #1302
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drsk0
force-pushed
the
add_baker_suspended
branch
from
December 18, 2024 14:38
2a48008
to
0d928fe
Compare
td202
requested changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would also be nice to have test coverage for this.
drsk0
force-pushed
the
add_baker_suspended
branch
3 times, most recently
from
January 7, 2025 11:18
582d052
to
ee13c96
Compare
working on the tests |
drsk0
commented
Jan 7, 2025
concordium-consensus/tests/globalstate/GlobalStateTests/ConfigureValidator.hs
Outdated
Show resolved
Hide resolved
drsk0
force-pushed
the
add_baker_suspended
branch
from
January 8, 2025 13:23
51f10ee
to
7db35b7
Compare
eb-concordium
approved these changes
Jan 8, 2025
td202
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks.
drsk0
force-pushed
the
add_baker_suspended
branch
4 times, most recently
from
January 9, 2025 14:02
db0bf65
to
7de4ad7
Compare
td202
reviewed
Jan 9, 2025
concordium-consensus/src/Concordium/GlobalState/Persistent/BlockState.hs
Show resolved
Hide resolved
drsk0
force-pushed
the
add_baker_suspended
branch
from
January 9, 2025 14:41
7de4ad7
to
59975e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #1246 . Validators can now be added already suspended.
Changes
Extends the
ValidatorAdd
field with a newvaSuspended
field.Checklist
hard-to-understand areas.
CLA acceptance
_Remove if not applicable.
By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0
link: https://developers.concordium.com/CLAs/Contributor-License-Agreement-v1.0.pdf
I accept the above linked CLA.