Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend ValidatorAdd with a suspended field #1302

Merged
merged 5 commits into from
Jan 9, 2025
Merged

Extend ValidatorAdd with a suspended field #1302

merged 5 commits into from
Jan 9, 2025

Conversation

drsk0
Copy link
Contributor

@drsk0 drsk0 commented Dec 16, 2024

Purpose

Closes #1246 . Validators can now be added already suspended.

Changes

Extends the ValidatorAdd field with a new vaSuspended field.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

CLA acceptance

_Remove if not applicable.

By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

@drsk0 drsk0 requested a review from eb-concordium December 16, 2024 15:31
@drsk0 drsk0 force-pushed the add_baker_suspended branch from 2a48008 to 0d928fe Compare December 18, 2024 14:38
Copy link
Contributor

@td202 td202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also be nice to have test coverage for this.

@drsk0 drsk0 force-pushed the add_baker_suspended branch 3 times, most recently from 582d052 to ee13c96 Compare January 7, 2025 11:18
@drsk0
Copy link
Contributor Author

drsk0 commented Jan 7, 2025

working on the tests

@drsk0 drsk0 force-pushed the add_baker_suspended branch from 51f10ee to 7db35b7 Compare January 8, 2025 13:23
@drsk0 drsk0 requested a review from td202 January 8, 2025 13:28
Copy link
Contributor

@td202 td202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks.

@drsk0 drsk0 force-pushed the add_baker_suspended branch 4 times, most recently from db0bf65 to 7de4ad7 Compare January 9, 2025 14:02
@drsk0 drsk0 force-pushed the add_baker_suspended branch from 7de4ad7 to 59975e0 Compare January 9, 2025 14:41
@drsk0 drsk0 merged commit 49088c7 into main Jan 9, 2025
3 checks passed
@drsk0 drsk0 deleted the add_baker_suspended branch January 9, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support suspend/resume in ValidatorAdd.
3 participants