add the tagname flag to allow arbitrary ec2 tags be the dns name #9
Conversation
|
This looks ok code-wise, but I'm curious as to what could be more useful than the Name tag? |
| if *tagname == "" { | ||
| // stupid strings ... | ||
| x := "Name" | ||
| tagname = &x |
There was a problem hiding this comment.
@timball I think you can just pass "Name" as the default parameter to flag.String.
|
okay i made the change for the string default, as far as "why did i do this?" it's because we used the ec2 "Name" a bit more freeform and have an ec2 tag "DNS" that represents the dns name i want servers to respond too . i was using some crazy powerdns + ec2tools nonsense . aws-name-server is more sane . took me exactly 20m to get it to do what i needed . 👍 --timball |
|
though right now i can't set an instances "Name" or "DNS" to anything w/ a dot ... so "server.group.domain" would be sweet . maybe i'll give it another 20m look --timball |
|
We could allow --tagname to take a dot-separated list of tagnames. If we then allow for multiple tagname arguments that would allow for very cool, easy flexibility. --tagname "DNS.Group" |
|
pull code ? or do you want me to give the --tagname a go ? |
this deals w/ #8
share and enjoy!
--timball