Added default fontSize to Heading #389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 0.10.0
… tests and snapshots.
# Conflicts: # src/Heading/index.js # storybook/stories/Heading.stories.js
|
Deploy preview for rimble-ui-storybook ready! Built with commit ba87543 |
|
Deploy preview for rimble-ui-storybook ready! Built with commit 2b4b0c1 |
|
Deploy preview for rimble-ui-storybook ready! Built with commit 76b8ef8 |
ryancreatescopy
approved these changes
Oct 23, 2019
|
@gesquinca this has been waiting for your review. Any feedback? |
|
I'm not really loving this particular solution. I'm exploring how other systems are handling this and why at the moment. |
|
Fixed in #421 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug where fontSize wasn't overriding default value.