fix: fixed comments and variable naming (#603)

Co-authored-by: Gautam Botrel <[email protected]>
Consensys · Jan 14, 2025 · faec8ec · faec8ec
1 parent 5e3e49f
commit faec8ec
Show file tree

Hide file tree

Showing 11 changed files with 44 additions and 44 deletions.
diff --git a/ecc/bls12-377/fr/fft/domain.go b/ecc/bls12-377/fr/fft/domain.go
diff --git a/ecc/bls12-381/fr/fft/domain.go b/ecc/bls12-381/fr/fft/domain.go
diff --git a/ecc/bls24-315/fr/fft/domain.go b/ecc/bls24-315/fr/fft/domain.go
diff --git a/ecc/bls24-317/fr/fft/domain.go b/ecc/bls24-317/fr/fft/domain.go
diff --git a/ecc/bn254/fr/fft/domain.go b/ecc/bn254/fr/fft/domain.go
diff --git a/ecc/bw6-633/fr/fft/domain.go b/ecc/bw6-633/fr/fft/domain.go
diff --git a/ecc/bw6-761/fr/fft/domain.go b/ecc/bw6-761/fr/fft/domain.go
diff --git a/field/babybear/fft/domain.go b/field/babybear/fft/domain.go
diff --git a/field/generator/internal/templates/fft/domain.go.tmpl b/field/generator/internal/templates/fft/domain.go.tmpl
@@ -38,10 +38,10 @@ type Domain struct {
 
 	// we precompute these mostly to avoid the memory intensive bit reverse permutation in the groth16.Prover
 
-	// cosetTable u*<1,g,..,g^(n-1)>
+	// cosetTable <1, u, u², ..., uⁿ⁻¹> where u is the shifting element
 	cosetTable         []{{ .FF }}.Element
 
-	// cosetTable[i][j] = domain.Generator(i-th)SqrtInv ^ j
+	// cosetTableInv same as cosetTable but with u⁻¹
 	cosetTableInv         []{{ .FF }}.Element
 }
 
@@ -142,8 +142,8 @@ func (d *Domain) preComputeTwiddles() {
 
 	var wg sync.WaitGroup
 
-	expTable := func(sqrt {{ .FF }}.Element, t []{{ .FF }}.Element) {
-		BuildExpTable(sqrt, t)
+	expTable := func(x {{ .FF }}.Element, t []{{ .FF }}.Element) {
+		BuildExpTable(x, t)
 		wg.Done()
 	}
 

diff --git a/field/goldilocks/fft/domain.go b/field/goldilocks/fft/domain.go
diff --git a/field/koalabear/fft/domain.go b/field/koalabear/fft/domain.go