style: remove old todos (#1106)

* style: remove old todos * style: removed TODO for checking staticcall * fix: update version --------- Co-authored-by: Thomas Piellard <[email protected]>
Consensys · Apr 22, 2024 · ea5cdf9 · ea5cdf9
1 parent b2dfec7
commit ea5cdf9
Show file tree

Hide file tree

Showing 10 changed files with 1 addition and 34 deletions.
diff --git a/backend/plonk/bls12-377/prove.go b/backend/plonk/bls12-377/prove.go
diff --git a/backend/plonk/bls12-381/prove.go b/backend/plonk/bls12-381/prove.go
diff --git a/backend/plonk/bls24-315/prove.go b/backend/plonk/bls24-315/prove.go
diff --git a/backend/plonk/bls24-317/prove.go b/backend/plonk/bls24-317/prove.go
diff --git a/backend/plonk/bn254/prove.go b/backend/plonk/bn254/prove.go
diff --git a/backend/plonk/bn254/solidity.go b/backend/plonk/bn254/solidity.go
diff --git a/backend/plonk/bw6-633/prove.go b/backend/plonk/bw6-633/prove.go
diff --git a/backend/plonk/bw6-761/prove.go b/backend/plonk/bw6-761/prove.go
diff --git a/doc.go b/doc.go
@@ -22,7 +22,7 @@ import (
 	"github.com/consensys/gnark-crypto/ecc"
 )
 
-var Version = semver.MustParse("0.10.0-alpha")
+var Version = semver.MustParse("0.10.0")
 
 // Curves return the curves supported by gnark
 func Curves() []ecc.ID {

diff --git a/internal/generator/backend/template/zkpschemes/plonk/plonk.prove.go.tmpl b/internal/generator/backend/template/zkpschemes/plonk/plonk.prove.go.tmpl
@@ -231,8 +231,6 @@ func newInstance(ctx context.Context, spr *cs.SparseR1CS, pk *ProvingKey, fullWi
 	} else {
 		s.domain1 = fft.NewDomain(4*sizeSystem, fft.WithoutPrecompute())
 	}
-	// TODO @gbotrel domain1 is used for only 1 FFT → precomputing the twiddles
-	// and storing them in memory is costly given its size. → do a FFT on the fly
 
 	// build trace
 	s.trace = NewTrace(spr, s.domain0)
@@ -1201,8 +1199,6 @@ func evaluateXnMinusOneDomainBigCoset(domains [2]*fft.Domain) []fr.Element {
 // - Z_{H}(ζ)*((H₀(X) + ζᵐ⁺²*H₁(X) + ζ²⁽ᵐ⁺²⁾*H₂(X))
 func (s *instance) innerComputeLinearizedPoly(lZeta, rZeta, oZeta, alpha, beta, gamma, zeta, zu fr.Element, qcpZeta, blindedZCanonical []fr.Element, pi2Canonical [][]fr.Element, pk *ProvingKey) []fr.Element {
 
-	// TODO @gbotrel rename
-
 	// l(ζ)r(ζ)
 	var rl fr.Element
 	rl.Mul(&rZeta, &lZeta)