perf: PairingCheck for BN254, BLS12-381, BLS12-377 and BW6-761

[yelhousni]

Description

This PR saves the squarings previously needed in AssertFinalExpIsOne for PairingCheck for BN254, BLS12-381, BLS12-377 and BW6-761 elliptic curves.

See discussion #1347.

Type of change

• New feature (non-breaking change which adds functionality)

How has this been tested?

TestPairingCheckTestSolve tests pass.

How has this been benchmarked?

The PR saves:

• 371,175 scs for BLS12-381,
• 238,793 scs for BN254,
• 4,272 scs for BLS12-377 and
• 1,195,718 scs for BW6-761.

Checklist:

• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• I did not modify files generated from templates
• golangci-lint does not output errors locally
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[shramee]

Look great to me!
Thanks for the great work! ❤️

[ivokub]

Looks good to me. However I think currently there is too much copied implementation. It works, but in the future when we want to target more optimizations/refactors then I'm afraid we could have mismatch between different code paths.

I would try to refactor common parts into separate functions and then use function calls instead. I can have a try at it.

[yelhousni]

Looks good to me. However I think currently there is too much copied implementation. It works, but in the future when we want to target more optimizations/refactors then I'm afraid we could have mismatch between different code paths.

I would try to refactor common parts into separate functions and then use function calls instead. I can have a try at it.

Right, I'll try to refactor some bits.