Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and use NodeJS v20 (LTS) #254

Merged
merged 9 commits into from
Jan 18, 2024
Merged

Update dependencies and use NodeJS v20 (LTS) #254

merged 9 commits into from
Jan 18, 2024

Conversation

blitz-1306
Copy link
Contributor

@blitz-1306 blitz-1306 commented Jan 18, 2024

Warning

This PR is based on #253. Merge #253 first, then retarget this PR to develop branch. This will leave a few changed files only.

Note

This PR would likely require a manual merge due to stuck absolete hooks, that no longer exist.

Changes

  • Update dependencies where possible. Note that VM.js got significantly updated, so there are related updates in VM test.
  • Updated VM test to use newer API.
  • Use NodeJS v20 (LTS) and updated GitHub actions to recent versions.

Regards.

@blitz-1306 blitz-1306 added the debt Cleanup/technical debt label Jan 18, 2024
@blitz-1306 blitz-1306 requested a review from cd1m0 January 18, 2024 08:43
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (1c27545) 87.22% compared to head (6740d75) 87.32%.
Report is 1 commits behind head on develop.

Files Patch % Lines
src/util/unicode.ts 80.55% 5 Missing and 2 partials ⚠️
src/util/json_output.ts 66.66% 0 Missing and 1 partial ⚠️
src/util/sources.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #254      +/-   ##
===========================================
+ Coverage    87.22%   87.32%   +0.09%     
===========================================
  Files           71       72       +1     
  Lines         5481     5539      +58     
  Branches      1236     1245       +9     
===========================================
+ Hits          4781     4837      +56     
+ Misses         416      415       -1     
- Partials       284      287       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@cd1m0 cd1m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cd1m0 cd1m0 merged commit c4f25bd into develop Jan 18, 2024
3 checks passed
@cd1m0 cd1m0 deleted the use-node-20 branch January 18, 2024 10:38
@blitz-1306 blitz-1306 mentioned this pull request Jan 18, 2024
Copy link

@hasti0073 hasti0073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Cleanup/technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants