Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗️ Upgrade to Nuxt 3 #79

Merged
merged 34 commits into from
Oct 11, 2024
Merged

🏗️ Upgrade to Nuxt 3 #79

merged 34 commits into from
Oct 11, 2024

Conversation

rudokemper
Copy link
Member

@rudokemper rudokemper commented Oct 11, 2024

Closes #36.

This PR upgrades the application from Nuxt 2 to 3 (and by proxy an upgrade from Vue 2 to 3).

As the migration documents note, "Nuxt 3 is a complete rewrite of Nuxt 2, and also based on a new set of underlying technologies." Hence, upgrading touched nearly every part of the application.1

Going granular on all of my changes would take me a long time, and I don't know that anyone is particularly keen on that level of detail; and much of it mirrors work in MapPacker on ConservationMetrics/map-packer#34.

However, what I would add is that this PR:

  • Utilizes the gc-shared-resources library for things like middleware, components, auth.
  • Makes much better use of the Composition API to logically organize blocks of code related to the same feature.
  • Adds vitest tests for most of the API server logic that relates to filtering or transforming data.
  • Makes a strong effort to improve typing for all server code.
  • Resolves all eslint / typescript warnings and errors.
  • Renames the application to "GuardianConnector Explorer"

What I'm not doing here:

Supporting building Docker images for arm in the Github workflows. Something about the refactor, or maybe the upgrade of the Docker image Node version, was breaking arm64, arm/v7 builds. So we'll have to figure that out later for Kakawa integration @luandro.

Footnotes

  1. I don't have the reference handy, but at some point I watched a video of a presentation by Evan You, the creator of Vue.js & Vite, where he described that upgrades moving forward will be much less painful, thankfully.

@rudokemper rudokemper merged commit fa3a424 into main Oct 11, 2024
1 check passed
@rudokemper rudokemper deleted the upgrade-to-nuxt-3 branch October 11, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Nuxt 3
1 participant