Skip to content

Commit

Permalink
(fix)[BaseEnvShell] set Shell_mode default to False
Browse files Browse the repository at this point in the history
  • Loading branch information
bmaisonneuve committed Jan 24, 2025
1 parent 82ab0e0 commit e5ef172
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/gws_core/impl/shell/base_env_shell.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def _generate_env_hash(self) -> str:
except Exception as err:
raise Exception(f"Error while reading the env file. Error {err}") from err

def run(self, cmd: Union[list, str], env: dict = None, shell_mode: bool = True) -> int:
def run(self, cmd: Union[list, str], env: dict = None, shell_mode: bool = False) -> int:
formatted_cmd = self.format_command(cmd)

# compute env
Expand All @@ -93,7 +93,7 @@ def run(self, cmd: Union[list, str], env: dict = None, shell_mode: bool = True)

return super().run(formatted_cmd, complete_env, shell_mode)

def run_in_new_thread(self, cmd: Union[list, str], env: dict = None, shell_mode: bool = True) -> SysProc:
def run_in_new_thread(self, cmd: Union[list, str], env: dict = None, shell_mode: bool = False) -> SysProc:
formatted_cmd = self.format_command(cmd)

# compute env
Expand Down

0 comments on commit e5ef172

Please sign in to comment.