2024-01-19 release #136
Merged
2024-01-19 release #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
설명: - 쿠폰의 상태를 요구사항에 있는 값과 동일하게 변경했습니다.
설명: - enum에서 value 필드의 값을 찾는 메소드를 포함한 인터페이스를 추가했습니다.
설명: - 파라미터를 String으로 모두 바꾸려 합니다. - 따라서 Converter는 필요가 없어졌으므로 삭제했습니다.
설명: - 새로 만든 ValuedEnum의 getValue로 유효성 검증을 하기 위해 ValuedEnumValidator를 수정했습니다.
설명 - #132 를 참고하세요. - 문자열로 요청을 받기 위해서는 타입을 문자열로 지정해줘야함을 알게되었습니다.
쿠폰 도메인 DTO의 enum 값을 요청/응답 시에 한글 값으로 받도록 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.