Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

CorentinB / warc Public

Notifications You must be signed in to change notification settings
Fork 5
Star 21

Code
Issues 3
Pull requests 1
Actions
Projects
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

Use cap() instead of len() to compute the spooling threshold#62

Merged

CorentinB merged 5 commits intomasterCorentinB/warc:masterfrom spooled-use-capCorentinB/warc:spooled-use-capCopy head branch name to clipboard

Jan 20, 2025

+17-8

Conversation Commits5 (5)Checks Files changed

Commits

Commits on Jan 20, 2025

feat: use cap() instead of len() to compute the spooling threshold
equals215
committed
feat: if the buffer is above the s.maxInMemorySize, don't return it in the pool but just discard it
equals215
committed
fix: compute the len of the buffer AND the cap when deciding to spool
equals215
committed
fix: TestThresholdCrossing as a buffer grow is expressed in a power of 2 and the buffer.cap() check when writing was making the test fail
equals215
committed
feat: also discard the buffer pointer if it's cap exceeded memory limit when closing
equals215
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.