Migrate to junit 5

Coreoz · Nov 21, 2024 · 70f14ff · 70f14ff
1 parent f152748
commit 70f14ff
Show file tree

Hide file tree

Showing 17 changed files with 134 additions and 121 deletions.
diff --git a/plume-file-core/pom.xml b/plume-file-core/pom.xml
@@ -53,14 +53,11 @@
 			<version>1.0.4</version>
 		</dependency>
 
-		<dependency>
-			<groupId>junit</groupId>
-			<artifactId>junit</artifactId>
-		</dependency>
-		<dependency>
-			<groupId>org.assertj</groupId>
-			<artifactId>assertj-core</artifactId>
-		</dependency>
+        <dependency>
+            <groupId>com.coreoz</groupId>
+            <artifactId>plume-test</artifactId>
+            <scope>test</scope>
+        </dependency>
 	</dependencies>
 
 	<dependencyManagement>

diff --git a/plume-file-core/src/test/java/com/coreoz/plume/file/cleaning/FileExtensionCleaningTest.java b/plume-file-core/src/test/java/com/coreoz/plume/file/cleaning/FileExtensionCleaningTest.java
@@ -1,6 +1,6 @@
 package com.coreoz.plume.file.cleaning;
 
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 import static org.assertj.core.api.Assertions.assertThat;
 

diff --git a/plume-file-core/src/test/java/com/coreoz/plume/file/cleaning/FileNameCleaningTest.java b/plume-file-core/src/test/java/com/coreoz/plume/file/cleaning/FileNameCleaningTest.java
@@ -1,6 +1,6 @@
 package com.coreoz.plume.file.cleaning;
 
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 import static org.assertj.core.api.Assertions.assertThat;
 

diff --git a/...le-core/src/test/java/com/coreoz/plume/file/service/data/MeasuredSizeInputStreamTest.java b/...le-core/src/test/java/com/coreoz/plume/file/service/data/MeasuredSizeInputStreamTest.java
@@ -1,7 +1,7 @@
 package com.coreoz.plume.file.service.data;
 
 import com.coreoz.plume.file.services.data.MeasuredSizeInputStream;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 import java.io.ByteArrayInputStream;
 import java.io.IOException;

diff --git a/...file-core/src/test/java/com/coreoz/plume/file/service/mimetype/MimeTypesDetectorTest.java b/...file-core/src/test/java/com/coreoz/plume/file/service/mimetype/MimeTypesDetectorTest.java
@@ -2,7 +2,7 @@
 
 import com.coreoz.plume.file.services.mimetype.MimeTypesDetector;
 import com.coreoz.plume.file.services.mimetype.PeekingInputStream;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 import java.io.ByteArrayOutputStream;
 import java.io.IOException;

diff --git a/...metadata-database/src/test/java/com/coreoz/plume/file/db/FileMetadataDatabaseDaoTest.java b/...metadata-database/src/test/java/com/coreoz/plume/file/db/FileMetadataDatabaseDaoTest.java
@@ -1,24 +1,19 @@
 package com.coreoz.plume.file.db;
 
-import java.util.Collections;
-import java.util.List;
-import java.util.Optional;
-
-import jakarta.inject.Inject;
-
-import org.junit.Assert;
-import org.junit.Test;
-import org.junit.runner.RunWith;
-
-import com.carlosbecker.guice.GuiceModules;
-import com.carlosbecker.guice.GuiceTestRunner;
 import com.coreoz.plume.file.filetype.FileTypeDatabase;
 import com.coreoz.plume.file.services.metadata.FileMetadata;
+import com.coreoz.test.GuiceTest;
 import com.querydsl.core.types.EntityPath;
 import com.querydsl.core.types.dsl.StringPath;
+import jakarta.inject.Inject;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+import java.util.Collections;
+import java.util.List;
+import java.util.Optional;
 
-@RunWith(GuiceTestRunner.class)
-@GuiceModules(FileTestModule.class)
+@GuiceTest(FileTestModule.class)
 public class FileMetadataDatabaseDaoTest {
     @Inject
     private FileMetadataDatabaseDao fileMetadataDao;
@@ -27,22 +22,22 @@ public class FileMetadataDatabaseDaoTest {
     public void fetch_should_return_value_if_present_in_database() {
         String uid = "7b3cf3de-f973-11e8-8eb2-f2801f1b9fd1";
         Optional<FileMetadata> fileMetadata = fileMetadataDao.fetch(uid);
-        Assert.assertTrue(fileMetadata.isPresent());
-        Assert.assertEquals(fileMetadata.get().getUniqueName(), uid);
+        Assertions.assertTrue(fileMetadata.isPresent());
+        Assertions.assertEquals(fileMetadata.get().getUniqueName(), uid);
     }
 
     @Test
     public void add_should_not_fail() {
         String uid = "c70f9b94-30e2-4e10-b84d-b964ef972067";
         fileMetadataDao.add(uid, "original_name", "TEST", "pdf", "application/pdf");
-        Assert.assertTrue(true);
+        Assertions.assertTrue(true);
     }
 
     @Test
     public void delete_should_not_fail() {
         String uid = "846c36cc-f973-11e8-8eb2-f2801f1b9fd1";
         long deleted = fileMetadataDao.deleteFilesMetadata(Collections.singletonList(uid));
-        Assert.assertEquals(1, deleted);
+        Assertions.assertEquals(1, deleted);
     }
 
     @Test
@@ -51,23 +46,23 @@ public void update_file_size_should_update_file_size() {
         fileMetadataDao.updateFileSizeAndChecksum(uid, 1L, "sha256");
 
         FileMetadata metadata = fileMetadataDao.fetch(uid).orElse(null);
-        Assert.assertNotNull(metadata);
-        Assert.assertEquals(1, metadata.getFileSize().intValue());
+        Assertions.assertNotNull(metadata);
+        Assertions.assertEquals(1, metadata.getFileSize().intValue());
     }
 
     @Test
     public void find_unreferenced_files_should_not_be_empty() {
         List<String> unreferencedFiles = fileMetadataDao.findUnreferencedFiles(List.of(TestFileType.TEST));
 
-        Assert.assertFalse(unreferencedFiles.isEmpty());
+        Assertions.assertFalse(unreferencedFiles.isEmpty());
     }
 
     @Test
     public void find_files_having_unused_known_type_should_return_1() {
         List<String> unreferencedFiles = fileMetadataDao.findFilesHavingDeletedTypes(List.of(TestFileType.TEST));
 
         // see file V1__file_setup.sql, there is only one file with the type TEST_DELETED
-        Assert.assertEquals(1, unreferencedFiles.size());
+        Assertions.assertEquals(1, unreferencedFiles.size());
     }
 
     private enum TestFileType implements FileTypeDatabase {

diff --git a/...database/src/test/java/com/coreoz/plume/file/service/FileMetadataDatabaseServiceTest.java b/...database/src/test/java/com/coreoz/plume/file/service/FileMetadataDatabaseServiceTest.java
@@ -7,13 +7,11 @@
 import java.util.List;
 import java.util.Optional;
 
-import org.junit.Assert;
-import org.junit.Before;
-import org.junit.Test;
-import org.junit.runner.RunWith;
+import com.coreoz.test.GuiceTest;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
 
-import com.carlosbecker.guice.GuiceModules;
-import com.carlosbecker.guice.GuiceTestRunner;
 import com.coreoz.plume.file.db.FileMetadataDatabaseDao;
 import com.coreoz.plume.file.db.beans.FileMetadataQuerydsl;
 import com.coreoz.plume.file.filetype.FileTypeDatabase;
@@ -23,46 +21,45 @@
 import com.querydsl.core.types.EntityPath;
 import com.querydsl.core.types.dsl.StringPath;
 
-@RunWith(GuiceTestRunner.class)
-@GuiceModules(FileTestModule.class)
+@GuiceTest(FileTestModule.class)
 public class FileMetadataDatabaseServiceTest {
     private FileMetadataService fileMetadataService;
 
-    @Before
+    @BeforeEach
     public void init_metadata_service() {
         this.fileMetadataService = new FileMetadataDatabaseService(this.mockDao, new TestTypeProvider());
     }
 
     @Test
     public void fetch_file_with_known_unique_file_name_must_return_object() {
         Optional<? extends FileMetadata> fileMetadata = this.fileMetadataService.fetch("random-uid-to-fetch");
-        Assert.assertTrue(fileMetadata.isPresent());
-        Assert.assertEquals("TEST", fileMetadata.get().getFileType());
-        Assert.assertEquals("application/pdf", fileMetadata.get().getMimeType());
+        Assertions.assertTrue(fileMetadata.isPresent());
+        Assertions.assertEquals("TEST", fileMetadata.get().getFileType());
+        Assertions.assertEquals("application/pdf", fileMetadata.get().getMimeType());
     }
 
     @Test
     public void fetch_file_with_unknown_unique_file_name_must_return_empty() {
         Optional<? extends FileMetadata> fileMetadata = this.fileMetadataService.fetch("unknown-uid-to-fetch");
-        Assert.assertFalse(fileMetadata.isPresent());
+        Assertions.assertFalse(fileMetadata.isPresent());
     }
 
     @Test
     public void upload_file_must_return_valid_id() {
         this.fileMetadataService.add("unknown-uid-to-fetch", "original_name", "TEST", "pdf", "application/pdf");
-        Assert.assertTrue(true);
+        Assertions.assertTrue(true);
     }
 
     @Test
     public void unreferenced_files_must_return_valid_list() {
         List<String> unreferencedFiles = this.fileMetadataService.findUnreferencedFiles();
-        Assert.assertEquals(0, unreferencedFiles.size());
+        Assertions.assertEquals(0, unreferencedFiles.size());
     }
 
     @Test
     public void unreferenced_files_must_not_fail() {
         this.fileMetadataService.deleteAll(Collections.singletonList("random-uid-to-fetch"));
-        Assert.assertTrue(true);
+        Assertions.assertTrue(true);
     }
 
     private final FileMetadataDatabaseDao mockDao = new FileMetadataDatabaseDao(null) {

diff --git a/plume-file-storage-database/src/test/java/com/coreoz/plume/file/db/FileStorageDaoTest.java b/plume-file-storage-database/src/test/java/com/coreoz/plume/file/db/FileStorageDaoTest.java
@@ -6,32 +6,28 @@
 import java.util.List;
 import java.util.Optional;
 
+import com.coreoz.plume.file.service.FileTestModule;
+import com.coreoz.test.GuiceTest;
 import jakarta.inject.Inject;
 
 import org.assertj.core.api.Assertions;
-import org.junit.Assert;
-import org.junit.Test;
-import org.junit.runner.RunWith;
+import org.junit.jupiter.api.Test;
 
-import com.carlosbecker.guice.GuiceModules;
-import com.carlosbecker.guice.GuiceTestRunner;
-
-@RunWith(GuiceTestRunner.class)
-@GuiceModules(FileTestModule.class)
+@GuiceTest(FileTestModule.class)
 public class FileStorageDaoTest {
     @Inject
     private FileStorageDao fileDao;
 
     @Test
     public void fetch_existing_file_should_return_the_file() {
         Optional<InputStream> file = fileDao.fetch("846c36cc-f973-11e8-8eb2-f2801f1b9fd1");
-        Assert.assertTrue(file.isPresent());
+        Assertions.assertThat(file).isPresent();
     }
 
     @Test
     public void fetch_unknown_file_should_return_empty() {
         Optional<InputStream> file = fileDao.fetch("unknown");
-        Assert.assertFalse(file.isPresent());
+        Assertions.assertThat(file).isEmpty();
     }
 
     @Test

diff --git a/...-database/src/test/java/com/coreoz/plume/file/service/FileStorageDatabaseServiceTest.java b/...-database/src/test/java/com/coreoz/plume/file/service/FileStorageDatabaseServiceTest.java
@@ -6,42 +6,39 @@
 import java.util.List;
 import java.util.Optional;
 
-import org.junit.Assert;
-import org.junit.Before;
-import org.junit.Test;
-import org.junit.runner.RunWith;
+import com.coreoz.test.GuiceTest;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
 
-import com.carlosbecker.guice.GuiceModules;
-import com.carlosbecker.guice.GuiceTestRunner;
 import com.coreoz.plume.file.db.FileStorageDao;
 
-@RunWith(GuiceTestRunner.class)
-@GuiceModules(FileTestModule.class)
+@GuiceTest(FileTestModule.class)
 public class FileStorageDatabaseServiceTest {
     private FileStorageDatabaseService fileStorageDatabase;
 
-    @Before
+    @BeforeEach
     public void init_metadata_service() {
         this.fileStorageDatabase = new FileStorageDatabaseService(this.mockDao);
     }
 
     @Test
     public void fetch_file_with_known_unique_file_name_must_return_byte_array() throws IOException {
         Optional<InputStream> fileMetadata = this.fileStorageDatabase.fetch("random-uid-to-fetch");
-        Assert.assertTrue(fileMetadata.isPresent());
-        Assert.assertEquals(-1, fileMetadata.get().read());
+        Assertions.assertTrue(fileMetadata.isPresent());
+        Assertions.assertEquals(-1, fileMetadata.get().read());
     }
 
     @Test
     public void fetch_file_with_unknown_unique_file_name_must_return_empty() {
         Optional<InputStream> bytes = this.fileStorageDatabase.fetch("unknown-uid-to-fetch");
-        Assert.assertFalse(bytes.isPresent());
+        Assertions.assertFalse(bytes.isPresent());
     }
 
     @Test
     public void upload_file_should_not_fail() throws IOException {
         this.fileStorageDatabase.add("random-uid-to-add", new ByteArrayInputStream(new byte[1]));
-        Assert.assertTrue(true);
+        Assertions.assertTrue(true);
     }
 
     private final FileStorageDao mockDao = new FileStorageDao(null) {

diff --git a/plume-file-storage-database/src/test/java/com/coreoz/plume/file/service/FileTestModule.java b/plume-file-storage-database/src/test/java/com/coreoz/plume/file/service/FileTestModule.java
@@ -1,13 +1,17 @@
 package com.coreoz.plume.file.service;
 
 import com.coreoz.plume.conf.guice.GuiceConfModule;
+import com.coreoz.plume.db.guice.DataSourceModule;
+import com.coreoz.plume.db.guice.GuiceDbTestModule;
 import com.google.inject.AbstractModule;
 
 public class FileTestModule extends AbstractModule {
 
 	@Override
 	protected void configure() {
-		install(new GuiceConfModule());
+        install(new GuiceConfModule());
+        install(new DataSourceModule());
+        install(new GuiceDbTestModule());
 	}
 
 }
diff --git a/...rage-system/src/test/java/com/coreoz/plume/file/service/FileStorageSystemServiceTest.java b/...rage-system/src/test/java/com/coreoz/plume/file/service/FileStorageSystemServiceTest.java
@@ -1,6 +1,6 @@
 package com.coreoz.plume.file.service;
 
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
 
 import java.io.IOException;
 

diff --git a/plume-file-web-download-jersey/pom.xml b/plume-file-web-download-jersey/pom.xml
@@ -57,6 +57,12 @@
 			<artifactId>guice</artifactId>
 			<optional>true</optional>
 		</dependency>
+
+        <dependency>
+            <groupId>com.coreoz</groupId>
+            <artifactId>plume-test</artifactId>
+            <scope>test</scope>
+        </dependency>
 	</dependencies>
 
 	<dependencyManagement>

diff --git a/...-download-jersey/src/test/java/com/coreoz/plume/file/service/FileDownloadServiceTest.java b/...-download-jersey/src/test/java/com/coreoz/plume/file/service/FileDownloadServiceTest.java
diff --git a/plume-file-web-upload-jersey/pom.xml b/plume-file-web-upload-jersey/pom.xml
@@ -64,16 +64,16 @@
 			<optional>true</optional>
 		</dependency>
 
-		<dependency>
-			<groupId>com.carlosbecker</groupId>
-			<artifactId>guice-junit-test-runner</artifactId>
-			<exclusions>
-				<exclusion>
-					<artifactId>guice</artifactId>
-					<groupId>com.google.inject</groupId>
-				</exclusion>
-			</exclusions>
-		</dependency>
+        <dependency>
+            <groupId>com.coreoz</groupId>
+            <artifactId>plume-test</artifactId>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>ch.qos.logback</groupId>
+            <artifactId>logback-classic</artifactId>
+            <scope>test</scope>
+        </dependency>
 	</dependencies>
 
 	<dependencyManagement>