Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Key/OwnedKey for cosmwasm_std types #94

Merged
merged 8 commits into from
Jan 30, 2025

Conversation

uint
Copy link
Collaborator

@uint uint commented Jan 28, 2025

Closes #57

TODO:

  • impls for cosmwasm_std::Uint* and cosmwasm_std::Int* types
  • API docs
  • (brownie points) a derive provided by storey that handles delegation
  • test the derive somehow!
    • got to love how the coverage hides the fact this stuff is untested except for "it compiles" ;)

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 96.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 91.60%. Comparing base (358546a) to head (ab00228).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
packages/cw-storey/src/containers/key_set.rs 91.26% 6 Missing and 3 partials ⚠️
packages/storey-macros/src/lib.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
+ Coverage   90.00%   91.60%   +1.59%     
==========================================
  Files          14       19       +5     
  Lines        2002     2216     +214     
  Branches     2002     2216     +214     
==========================================
+ Hits         1802     2030     +228     
+ Misses        179      161      -18     
- Partials       21       25       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uint uint marked this pull request as ready for review January 30, 2025 13:44
@uint uint merged commit 95e6f54 into main Jan 30, 2025
5 checks passed
@uint uint deleted the 57-impl-ownedkey-for-cosmwasmstd-types branch January 30, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement OwnedKey for cosmwasm_std types somehow
1 participant