Linter PR 3: enable additional linters #589
Conversation
|
@webmaster128 please check this out, as well as the other, related pull requests. |
There was a problem hiding this comment.
Not a full review.
I am interested in the linters (and the fixes that make them happy), but there are lots of unrelated changes in here that need to be discussed. I would appreciate if we keep these in separate PRs, so they don't block the us from merging the linters.
| if err != nil && err.(syscall.Errno) != C.ErrnoValue_Success { | ||
| if err != nil && err.(syscall.Errno) != 0 { |
There was a problem hiding this comment.
Why this change? I like the constant here because it makes it clear immediately that this is the unsuccessful case.
There was a problem hiding this comment.
can it ever return anything other than the constant?
The purpose of the change is to ensure that it catches all errors.
There was a problem hiding this comment.
How does this change "ensure that it catches all errors"?
| @@ -1,6 +1,6 @@ | |||
| module github.com/CosmWasm/wasmvm/v2 | |||
|
|
|||
| go 1.21 | |||
| go 1.23 | |||
There was a problem hiding this comment.
Is this required for the linters?
There was a problem hiding this comment.
for copyloopvar, and best practices
|
Hey, I hope I was sufficiently clear, I was writing from mobile before. @webmaster128 asked for smaller PRs. This is the largest of them. You'd want to review:
Before this one -- as for your review comments, thanks! I will resolve issues with this PR shortly, but will remind that I was explicitly asked to make smaller PRs after a PR had sat for about 2 years. And to be real, if the linters were interesting, I think it would not have sat for two years. |
faddat
changed the title
This pull request adds additional linters and works towards a more ideal configuration for the linter.
This is the most completely linted version. Before reviewing this, I do recommend that you review The pull requests that are in the style requested by @webmaster128
He asked for multiple PRS, each enabling more linters. This is the last of them.